netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] amt: fix wrong return type of amt_send_membership_update()
@ 2022-01-09 16:37 Taehee Yoo
  2022-01-10  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Taehee Yoo @ 2022-01-09 16:37 UTC (permalink / raw)
  To: davem, kuba, netdev; +Cc: ap420073

amt_send_membership_update() would return -1 but it's return type is bool.
So, it should be used TRUE instead of -1.

Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
 drivers/net/amt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index b732ee9a50ef..d3a9dda6c728 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -1106,7 +1106,7 @@ static bool amt_send_membership_query(struct amt_dev *amt,
 	rt = ip_route_output_key(amt->net, &fl4);
 	if (IS_ERR(rt)) {
 		netdev_dbg(amt->dev, "no route to %pI4\n", &tunnel->ip4);
-		return -1;
+		return true;
 	}
 
 	amtmq		= skb_push(skb, sizeof(*amtmq));
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] amt: fix wrong return type of amt_send_membership_update()
  2022-01-09 16:37 [PATCH net] amt: fix wrong return type of amt_send_membership_update() Taehee Yoo
@ 2022-01-10  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-01-10  1:00 UTC (permalink / raw)
  To: Taehee Yoo; +Cc: davem, kuba, netdev

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun,  9 Jan 2022 16:37:02 +0000 you wrote:
> amt_send_membership_update() would return -1 but it's return type is bool.
> So, it should be used TRUE instead of -1.
> 
> Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net] amt: fix wrong return type of amt_send_membership_update()
    https://git.kernel.org/netdev/net/c/dd3ca4c5184e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-10  1:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-09 16:37 [PATCH net] amt: fix wrong return type of amt_send_membership_update() Taehee Yoo
2022-01-10  1:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).