From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Subject: Re: [PATCH net] net: mscc: ocelot: don't let phylink re-enable TX PAUSE on the NPI port
Date: Wed, 12 Jan 2022 20:37:31 +0000 [thread overview]
Message-ID: <20220112203731.73d7weqpxd2vbvzd@skbuf> (raw)
In-Reply-To: <2662f157-fa92-8a99-473a-9ca5f7887d28@gmail.com>
On Wed, Jan 12, 2022 at 12:31:14PM -0800, Florian Fainelli wrote:
> Still quite a lot of retries, do you know where they are coming from?
Yes, they are coming from the fact that the CPU port runs at 2.5G and
the front port at 1G, and as mentioned, there isn't any flow control
when the CPU port is used in NPI mode.
Flow control on that port pair _is_ available when the CPU port is used
with the ocelot-8021q tagging protocol, which is the reason why I
updated the device tree to declare "pause" for those fixed-links.
We can't enable or disable flow control on a fixed-link at runtime in
Linux.
next prev parent reply other threads:[~2022-01-12 20:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 20:21 [PATCH net] net: mscc: ocelot: don't let phylink re-enable TX PAUSE on the NPI port Vladimir Oltean
2022-01-12 20:31 ` Florian Fainelli
2022-01-12 20:37 ` Vladimir Oltean [this message]
2022-01-13 13:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112203731.73d7weqpxd2vbvzd@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).