From: Corinna Vinschen <vinschen@redhat.com>
To: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org
Cc: Andre Guedes <andre.guedes@intel.com>,
Sasha Neftin <sasha.neftin@intel.com>
Subject: [PATCH net-next] igc: avoid kernel warning when changing RX ring parameters
Date: Thu, 13 Jan 2022 17:00:21 +0100 [thread overview]
Message-ID: <20220113160021.1027704-1-vinschen@redhat.com> (raw)
Calling ethtool changing the RX ring parameters like this:
$ ethtool -G eth0 rx 1024
triggers the "Missing unregister, handled but fix driver" warning in
xdp_rxq_info_reg().
igc_ethtool_set_ringparam() copies the igc_ring structure but neglects to
reset the xdp_rxq_info member before calling igc_setup_rx_resources().
This in turn calls xdp_rxq_info_reg() with an already registered xdp_rxq_info.
This fix initializes the xdp_rxq_info member prior to calling
igc_setup_rx_resources(), exactly like igb.
Fixes: 73f1071c1d29 ("igc: Add support for XDP_TX action")
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 8cc077b712ad..93839106504d 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -671,6 +671,10 @@ igc_ethtool_set_ringparam(struct net_device *netdev,
memcpy(&temp_ring[i], adapter->rx_ring[i],
sizeof(struct igc_ring));
+ /* Clear copied XDP RX-queue info */
+ memset(&temp_ring[i].xdp_rxq, 0,
+ sizeof(temp_ring[i].xdp_rxq));
+
temp_ring[i].count = new_rx_count;
err = igc_setup_rx_resources(&temp_ring[i]);
if (err) {
--
2.27.0
next reply other threads:[~2022-01-13 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 16:00 Corinna Vinschen [this message]
2022-01-14 0:37 ` [PATCH net-next] igc: avoid kernel warning when changing RX ring parameters Vinicius Costa Gomes
2022-01-14 10:27 ` [Intel-wired-lan] " Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113160021.1027704-1-vinschen@redhat.com \
--to=vinschen@redhat.com \
--cc=andre.guedes@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).