From: Steffen Klassert <steffen.klassert@secunet.com>
To: Yan Yan <evitayan@google.com>
Cc: netdev@vger.kernel.org,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Lorenzo Colitti" <lorenzo@google.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Nathan Harold" <nharold@google.com>,
"Benedict Wong" <benedictwong@google.com>
Subject: Re: [PATCH v1 1/2] xfrm: Check if_id in xfrm_migrate
Date: Mon, 17 Jan 2022 12:46:31 +0100 [thread overview]
Message-ID: <20220117114631.GG1223722@gauss3.secunet.de> (raw)
In-Reply-To: <CADHa2dAaG4Pgxk7gmDbBnVSYJ_eBtJY3KaR94fY=wp+Pmt0EoA@mail.gmail.com>
Hi Yan,
On Wed, Jan 12, 2022 at 02:53:31PM -0800, Yan Yan wrote:
> Hi Steffen,
>
> The Jan 7th patch fixes the following warning (reported by the kernel
> test robot) by adding parentheses.
> net/xfrm/xfrm_policy.c: In function 'xfrm_migrate':
> >> net/xfrm/xfrm_policy.c:4403:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
> 4403 | if (x = xfrm_migrate_state_find(mp, net, if_id)) {
> | ^
>
> In the Jan 7th patch, this line becomes "if ((x =
> xfrm_migrate_state_find(mp, net, if_id))) {"
I thought that was already fixed in the previous version.
Please mark updated patches as v2 etc. and describe the
changes you did in the new version.
Please resend your patchset and add a proper 'Fixes:'
tag to the patches.
Thanks!
next prev parent reply other threads:[~2022-01-17 11:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 1:32 [PATCH v1 1/2] xfrm: Check if_id in xfrm_migrate Yan Yan
2022-01-12 7:32 ` Steffen Klassert
2022-01-12 22:53 ` Yan Yan
2022-01-17 11:46 ` Steffen Klassert [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-06 0:52 [PATCH v1 0/2] Fix issues " Yan Yan
2022-01-06 0:52 ` [PATCH v1 1/2] xfrm: Check if_id " Yan Yan
2021-12-23 0:45 [PATCH v1 0/2] Fix issues " Yan Yan
2021-12-23 0:45 ` [PATCH v1 1/2] xfrm: Check if_id " Yan Yan
2021-12-25 18:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117114631.GG1223722@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=benedictwong@google.com \
--cc=davem@davemloft.net \
--cc=evitayan@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nharold@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).