From: Stephen Hemminger <stephen@networkplumber.org>
To: Wen Liang <liangwen12year@gmail.com>
Cc: netdev@vger.kernel.org, dsahern@gmail.com, aclaudi@redhat.com
Subject: Re: [PATCH iproute2 v4 2/2] tc: u32: add json support in `print_raw`, `print_ipv4`, `print_ipv6`
Date: Mon, 17 Jan 2022 20:32:54 -0800 [thread overview]
Message-ID: <20220117203254.2ef76af1@hermes.local> (raw)
In-Reply-To: <562f7200730502e65486cac9341cdbedac84c5be.1642472827.git.wenliang@redhat.com>
On Mon, 17 Jan 2022 21:42:21 -0500
Wen Liang <liangwen12year@gmail.com> wrote:
> Signed-off-by: Wen Liang <liangwen12year@gmail.com>
More checkpatch warnings, please fix.
WARNING: Missing commit description - Add an appropriate one
WARNING: suspect code indent for conditional statements (24, 33)
#100: FILE: tc/f_u32.c:855:
if (bits >= 0) {
+ const char *addr;
WARNING: Statements should start on a tabstop
#106: FILE: tc/f_u32.c:856:
+ const char *addr;
WARNING: Statements should start on a tabstop
#107: FILE: tc/f_u32.c:857:
+ if (key->off == 12) {
WARNING: Missing a blank line after declarations
#107: FILE: tc/f_u32.c:857:
+ const char *addr;
+ if (key->off == 12) {
WARNING: suspect code indent for conditional statements (33, 39)
#107: FILE: tc/f_u32.c:857:
+ if (key->off == 12) {
+ print_nl();
WARNING: Statements should start on a tabstop
#111: FILE: tc/f_u32.c:861:
+ } else {
WARNING: suspect code indent for conditional statements (33, 39)
#111: FILE: tc/f_u32.c:861:
+ } else {
+ print_nl();
WARNING: Statements should start on a tabstop
#115: FILE: tc/f_u32.c:865:
+ }
WARNING: Missing a blank line after declarations
#200: FILE: tc/f_u32.c:933:
+ const char *addr;
+ if (key->off == 12) {
WARNING: suspect code indent for conditional statements (32, 38)
#200: FILE: tc/f_u32.c:933:
+ if (key->off == 12) {
+ print_nl();
ERROR: code indent should use tabs where possible
#201: FILE: tc/f_u32.c:934:
+^I^I^I print_nl();$
WARNING: suspect code indent for conditional statements (32, 38)
#204: FILE: tc/f_u32.c:937:
+ } else {
+ print_nl();
ERROR: code indent should use tabs where possible
#205: FILE: tc/f_u32.c:938:
+^I^I^I print_nl();$
total: 2 errors, 12 warnings, 198 lines checked
prev parent reply other threads:[~2022-01-18 4:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 2:42 [PATCH iproute2 v4 0/2] add json support on tc u32 Wen Liang
2022-01-18 2:42 ` [PATCH iproute2 v4 1/2] tc: u32: add support for json output Wen Liang
2022-01-18 4:30 ` Stephen Hemminger
2022-01-18 20:04 ` David Ahern
2022-01-18 2:42 ` [PATCH iproute2 v4 2/2] tc: u32: add json support in `print_raw`, `print_ipv4`, `print_ipv6` Wen Liang
2022-01-18 4:32 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117203254.2ef76af1@hermes.local \
--to=stephen@networkplumber.org \
--cc=aclaudi@redhat.com \
--cc=dsahern@gmail.com \
--cc=liangwen12year@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).