From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Machata <petrm@nvidia.com>
Cc: David Ahern <dsahern@gmail.com>, <netdev@vger.kernel.org>,
Maksym Yaremchuk <maksymy@nvidia.com>
Subject: Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio"
Date: Wed, 19 Jan 2022 12:35:06 -0800 [thread overview]
Message-ID: <20220119123506.2360b139@hermes.local> (raw)
In-Reply-To: <87pmooove2.fsf@nvidia.com>
On Wed, 19 Jan 2022 11:38:54 +0100
Petr Machata <petrm@nvidia.com> wrote:
> >
> > In general, we are not allowing more uses of matches(). I think this one
> > can be an exception for consistency with the other options, so really
> > just a heads up.
>
> The shortening that the matches() allows is very useful for typing. I do
> stuff like "ip l sh dev X up" and "ip a a dev X 192.0.2.1/28" all the
> time. I suppose there was a discussion about this, can you point me at
> the thread, or where & when approximately it took place so I can look it
> up?
The problem is that matches() doesn't handle conflicts well.
Using your example:
ip l
could match "ip link" or "ip l2tp" and the choice of "link" is only because
it was added first. This is bad UI, and creates tribal knowledge that makes
it harder for new users. Other utilities don't allow ambiguous matches.
next prev parent reply other threads:[~2022-01-19 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 11:36 [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio" Petr Machata
2022-01-19 2:44 ` David Ahern
2022-01-19 10:38 ` Petr Machata
2022-01-19 20:35 ` Stephen Hemminger [this message]
2022-01-19 23:39 ` David Ahern
2022-01-19 20:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119123506.2360b139@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=maksymy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).