From: Stephen Hemminger <stephen@networkplumber.org>
To: Petr Machata <petrm@nvidia.com>
Cc: <netdev@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
"Maksym Yaremchuk" <maksymy@nvidia.com>
Subject: Re: [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio"
Date: Wed, 19 Jan 2022 12:36:57 -0800 [thread overview]
Message-ID: <20220119123657.51d3e027@hermes.local> (raw)
In-Reply-To: <f6e07ca31e33a673f641c9282e81ee9c3be03d3c.1642505737.git.petrm@nvidia.com>
On Tue, 18 Jan 2022 12:36:44 +0100
Petr Machata <petrm@nvidia.com> wrote:
> + } else if (matches(*argv, "default-prio") == 0) {
> + dcb_app_print_default_prio(&tab);
> } else if (matches(*argv, "dscp-prio") == 0) {
> dcb_app_print_dscp_prio(dcb, &tab);
This is an example of why matches() sucks.
Existing users using:
dcp app show dev X d
will now get different behavior.
You need to redo this patch and put the new argument after "dscp-pri"
prev parent reply other threads:[~2022-01-19 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 11:36 [PATCH iproute2] dcb: app: Add missing "dcb app show dev X default-prio" Petr Machata
2022-01-19 2:44 ` David Ahern
2022-01-19 10:38 ` Petr Machata
2022-01-19 20:35 ` Stephen Hemminger
2022-01-19 23:39 ` David Ahern
2022-01-19 20:36 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119123657.51d3e027@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=maksymy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).