From: Jason Gunthorpe <jgg@ziepe.ca>
To: Praveen Kannoju <praveen.kannoju@oracle.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
"David S . Miller" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rama Nichanamatlu <rama.nichanamatlu@oracle.com>,
Rajesh Sivaramasubramaniom
<rajesh.sivaramasubramaniom@oracle.com>
Subject: Re: [PATCH RFC] rds: ib: Reduce the contention caused by the asynchronous workers to flush the mr pool
Date: Wed, 19 Jan 2022 09:04:50 -0400 [thread overview]
Message-ID: <20220119130450.GJ8034@ziepe.ca> (raw)
In-Reply-To: <PH0PR10MB5515E99CA5DF423BDEBB038E8C599@PH0PR10MB5515.namprd10.prod.outlook.com>
On Wed, Jan 19, 2022 at 11:46:16AM +0000, Praveen Kannoju wrote:
> 6. Jason, the only function "rds_ib_free_mr" which accesses the
> introduced bool variable "flush_ongoing" to spawn a flush worker
> does not crucially impact the availability of MR's, because the
> flush happens from allocation path as well when necessary. Hence
> the Load-store ordering is not essentially needed here, because of
> which we chose smp_rmb() and smp_wmb() over smp_load_acquire() and
> smp_store_release().
That seems like a confusing statement, you added barriers which do the
same things as acquire/release then say you didn't need acquire
release?
I think this is using barriers wrong.
Jason
next prev parent reply other threads:[~2022-01-19 13:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 14:47 [PATCH RFC] rds: ib: Reduce the contention caused by the asynchronous workers to flush the mr pool Praveen Kumar Kannoju
2022-01-18 16:48 ` Santosh Shilimkar
2022-01-18 18:00 ` Leon Romanovsky
2022-01-18 19:17 ` Jason Gunthorpe
2022-01-18 19:42 ` Santosh Shilimkar
2022-01-19 6:59 ` Leon Romanovsky
2022-01-19 11:46 ` Praveen Kannoju
2022-01-19 13:04 ` Jason Gunthorpe [this message]
2022-01-19 13:12 ` Praveen Kannoju
2022-01-19 13:17 ` Jason Gunthorpe
2022-01-19 14:08 ` Praveen Kannoju
2022-01-19 14:49 ` Jason Gunthorpe
2022-01-19 14:56 ` Leon Romanovsky
2022-01-20 8:00 ` Praveen Kannoju
2022-01-20 11:11 ` Leon Romanovsky
2022-01-20 11:57 ` Praveen Kannoju
2022-01-20 12:21 ` Leon Romanovsky
2022-01-20 12:27 ` Praveen Kannoju
-- strict thread matches above, loose matches on Subject: below --
2022-01-18 13:10 Praveen Kumar Kannoju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119130450.GJ8034@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=praveen.kannoju@oracle.com \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=rama.nichanamatlu@oracle.com \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).