From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, jiri@mellanox.com
Subject: [PATCH iproute2] tc/action: print error to stderr
Date: Thu, 20 Jan 2022 13:06:46 -0800 [thread overview]
Message-ID: <20220120210646.189197-1-stephen@networkplumber.org> (raw)
Error messages should go to stderr even if using JSON.
Fixes: 2704bd625583 ("tc: jsonify actions core")
Cc: jiri@mellanox.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
tc/m_action.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tc/m_action.c b/tc/m_action.c
index b16882a345dc..ee32aeda98fd 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -466,10 +466,8 @@ tc_print_action(FILE *f, const struct rtattr *arg, unsigned short tot_acts)
print_nl();
print_uint(PRINT_ANY, "order",
"\taction order %u: ", i);
- if (tc_print_one_action(f, tb[i]) < 0) {
- print_string(PRINT_FP, NULL,
- "Error printing action\n", NULL);
- }
+ if (tc_print_one_action(f, tb[i]) < 0)
+ fprintf(stderr, "Error printing action\n");
close_json_object();
}
--
2.30.2
next reply other threads:[~2022-01-20 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 21:06 Stephen Hemminger [this message]
2022-01-20 21:10 ` [PATCH iproute2] tc/action: print error to stderr patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120210646.189197-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).