From: Zhu Lingshan <lingshan.zhu@intel.com>
To: mst@redhat.com, jasowang@redhat.com
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH V2 3/4] vhost_vdpa: don't setup irq offloading when irq_num < 0
Date: Tue, 25 Jan 2022 17:17:43 +0800 [thread overview]
Message-ID: <20220125091744.115996-4-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220125091744.115996-1-lingshan.zhu@intel.com>
When irq number is negative(e.g., -EINVAL), the virtqueue
may be disabled or the virtqueues are sharing a device irq.
In such case, we should not setup irq offloading for a virtqueue.
Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
drivers/vhost/vdpa.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index 851539807bc9..909891d518e8 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -96,6 +96,9 @@ static void vhost_vdpa_setup_vq_irq(struct vhost_vdpa *v, u16 qid)
if (!ops->get_vq_irq)
return;
+ if (irq < 0)
+ return;
+
irq = ops->get_vq_irq(vdpa, qid);
irq_bypass_unregister_producer(&vq->call_ctx.producer);
if (!vq->call_ctx.ctx || irq < 0)
--
2.27.0
next prev parent reply other threads:[~2022-01-25 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 9:17 [PATCH V2 0/4] vDPA/ifcvf: implement shared IRQ feature Zhu Lingshan
2022-01-25 9:17 ` [PATCH V2 1/4] vDPA/ifcvf: implement IO read/write helpers in the header file Zhu Lingshan
2022-01-25 9:17 ` [PATCH V2 2/4] vDPA/ifcvf: implement device MSIX vector allocator Zhu Lingshan
2022-01-25 19:36 ` Michael S. Tsirkin
2022-01-26 12:18 ` Zhu, Lingshan
2022-01-25 9:17 ` Zhu Lingshan [this message]
2022-01-25 19:17 ` [PATCH V2 3/4] vhost_vdpa: don't setup irq offloading when irq_num < 0 kernel test robot
2022-01-25 19:30 ` Michael S. Tsirkin
2022-01-26 12:18 ` Zhu, Lingshan
2022-01-25 9:17 ` [PATCH V2 4/4] vDPA/ifcvf: implement shared IRQ feature Zhu Lingshan
2022-01-25 19:42 ` Michael S. Tsirkin
2022-01-26 12:22 ` Zhu, Lingshan
2022-01-25 19:32 ` [PATCH V2 0/4] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125091744.115996-4-lingshan.zhu@intel.com \
--to=lingshan.zhu@intel.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).