From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, dave@thedillows.org,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net 3/3] ethernet: broadcom/sb1250-mac: don't write directly to netdev->dev_addr
Date: Tue, 25 Jan 2022 14:23:17 -0800 [thread overview]
Message-ID: <20220125222317.1307561-4-kuba@kernel.org> (raw)
In-Reply-To: <20220125222317.1307561-1-kuba@kernel.org>
netdev->dev_addr is const now.
Compile tested bigsur_defconfig and sb1250_swarm_defconfig.
Fixes: adeef3e32146 ("net: constify netdev->dev_addr")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/broadcom/sb1250-mac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
index f38f40eb966e..a1a38456c9a3 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -2183,9 +2183,7 @@ static int sbmac_init(struct platform_device *pldev, long long base)
ea_reg >>= 8;
}
- for (i = 0; i < 6; i++) {
- dev->dev_addr[i] = eaddr[i];
- }
+ eth_hw_addr_set(dev, eaddr);
/*
* Initialize context (get pointers to registers and stuff), then
--
2.34.1
next prev parent reply other threads:[~2022-01-25 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 22:23 [PATCH net 0/3] ethernet: fix some esoteric drivers after netdev->dev_addr constification Jakub Kicinski
2022-01-25 22:23 ` [PATCH net 1/3] ethernet: 3com/typhoon: don't write directly to netdev->dev_addr Jakub Kicinski
2022-01-26 3:07 ` David Dillow
2022-01-25 22:23 ` [PATCH net 2/3] ethernet: tundra: " Jakub Kicinski
2022-01-25 22:23 ` Jakub Kicinski [this message]
2022-01-25 22:28 ` [PATCH net 0/3] ethernet: fix some esoteric drivers after netdev->dev_addr constification Jakub Kicinski
2022-01-25 23:59 ` Arnd Bergmann
2022-01-26 0:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125222317.1307561-4-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=dave@thedillows.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).