[PATCH] i40e: remove enum i40e_client_state

[PATCH] i40e: remove enum i40e_client_state

[Jakub Kicinski]

It's not used.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 include/linux/net/intel/i40e_client.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/net/intel/i40e_client.h
index 6b3267b49755..ed42bd5f639f 100644
--- a/include/linux/net/intel/i40e_client.h
+++ b/include/linux/net/intel/i40e_client.h
@@ -26,11 +26,6 @@ struct i40e_client_version {
 	u8 rsvd;
 };
 
-enum i40e_client_state {
-	__I40E_CLIENT_NULL,
-	__I40E_CLIENT_REGISTERED
-};
-
 enum i40e_client_instance_state {
 	__I40E_CLIENT_INSTANCE_NONE,
 	__I40E_CLIENT_INSTANCE_OPENED,
@@ -190,11 +185,6 @@ struct i40e_client {
 	const struct i40e_client_ops *ops; /* client ops provided by the client */
 };
 
-static inline bool i40e_client_is_registered(struct i40e_client *client)
-{
-	return test_bit(__I40E_CLIENT_REGISTERED, &client->state);
-}
-
 void i40e_client_device_register(struct i40e_info *ldev, struct i40e_client *client);
 void i40e_client_device_unregister(struct i40e_info *ldev);
 
-- 
2.34.1

Re: [PATCH] i40e: remove enum i40e_client_state

[Jesse Brandeburg]

Thanks Jakub!

On 1/26/2022 10:55 AM, Jakub Kicinski wrote:
> It's not used.

minor nit, you didn't say if you wanted this to go to net or net-next or 
add a Fixes: tag?

maybe:
Fixes: e3219ce6a775 ("i40e: Add support for client interface for IWARP 
driver")



> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

for the patch itself, it looks fine to me, so if you spin this
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>


> ---
>   include/linux/net/intel/i40e_client.h | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/net/intel/i40e_client.h
> index 6b3267b49755..ed42bd5f639f 100644
> --- a/include/linux/net/intel/i40e_client.h
> +++ b/include/linux/net/intel/i40e_client.h
> @@ -26,11 +26,6 @@ struct i40e_client_version {
>   	u8 rsvd;
>   };
>   
> -enum i40e_client_state {
> -	__I40E_CLIENT_NULL,
> -	__I40E_CLIENT_REGISTERED
> -};
> -
>   enum i40e_client_instance_state {
>   	__I40E_CLIENT_INSTANCE_NONE,
>   	__I40E_CLIENT_INSTANCE_OPENED,
> @@ -190,11 +185,6 @@ struct i40e_client {
>   	const struct i40e_client_ops *ops; /* client ops provided by the client */
>   };
>   
> -static inline bool i40e_client_is_registered(struct i40e_client *client)
> -{
> -	return test_bit(__I40E_CLIENT_REGISTERED, &client->state);
> -}
> -
>   void i40e_client_device_register(struct i40e_info *ldev, struct i40e_client *client);
>   void i40e_client_device_unregister(struct i40e_info *ldev);
>   

Re: [PATCH] i40e: remove enum i40e_client_state

[Jakub Kicinski]

On Wed, 26 Jan 2022 11:53:29 -0800 Jesse Brandeburg wrote:
> On 1/26/2022 10:55 AM, Jakub Kicinski wrote:
> > It's not used.  
> 
> minor nit, you didn't say if you wanted this to go to net or net-next or 
> add a Fixes: tag?

Right, I'm not targeting net or net-next directly. I should have put
something like "intel-next", probably.

> maybe:
> Fixes: e3219ce6a775 ("i40e: Add support for client interface for IWARP 
> driver")
> 
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> 
> for the patch itself, it looks fine to me, so if you spin this
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

RE: [Intel-wired-lan] [PATCH] i40e: remove enum i40e_client_state

[G, GurucharanX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jakub Kicinski
> Sent: Thursday, January 27, 2022 12:26 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Saleem, Shiraz
> <shiraz.saleem@intel.com>; Jakub Kicinski <kuba@kernel.org>
> Subject: [Intel-wired-lan] [PATCH] i40e: remove enum i40e_client_state
> 
> It's not used.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>  include/linux/net/intel/i40e_client.h | 10 ----------
>  1 file changed, 10 deletions(-)
> 

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)