* [PATCH] i40e: remove enum i40e_client_state
@ 2022-01-26 18:55 Jakub Kicinski
2022-01-26 19:53 ` Jesse Brandeburg
2022-01-31 5:39 ` [Intel-wired-lan] " G, GurucharanX
0 siblings, 2 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-01-26 18:55 UTC (permalink / raw)
To: anthony.l.nguyen; +Cc: shiraz.saleem, netdev, intel-wired-lan, Jakub Kicinski
It's not used.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
include/linux/net/intel/i40e_client.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/net/intel/i40e_client.h
index 6b3267b49755..ed42bd5f639f 100644
--- a/include/linux/net/intel/i40e_client.h
+++ b/include/linux/net/intel/i40e_client.h
@@ -26,11 +26,6 @@ struct i40e_client_version {
u8 rsvd;
};
-enum i40e_client_state {
- __I40E_CLIENT_NULL,
- __I40E_CLIENT_REGISTERED
-};
-
enum i40e_client_instance_state {
__I40E_CLIENT_INSTANCE_NONE,
__I40E_CLIENT_INSTANCE_OPENED,
@@ -190,11 +185,6 @@ struct i40e_client {
const struct i40e_client_ops *ops; /* client ops provided by the client */
};
-static inline bool i40e_client_is_registered(struct i40e_client *client)
-{
- return test_bit(__I40E_CLIENT_REGISTERED, &client->state);
-}
-
void i40e_client_device_register(struct i40e_info *ldev, struct i40e_client *client);
void i40e_client_device_unregister(struct i40e_info *ldev);
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i40e: remove enum i40e_client_state
2022-01-26 18:55 [PATCH] i40e: remove enum i40e_client_state Jakub Kicinski
@ 2022-01-26 19:53 ` Jesse Brandeburg
2022-01-26 19:59 ` Jakub Kicinski
2022-01-31 5:39 ` [Intel-wired-lan] " G, GurucharanX
1 sibling, 1 reply; 4+ messages in thread
From: Jesse Brandeburg @ 2022-01-26 19:53 UTC (permalink / raw)
To: Jakub Kicinski, anthony.l.nguyen; +Cc: shiraz.saleem, netdev, intel-wired-lan
Thanks Jakub!
On 1/26/2022 10:55 AM, Jakub Kicinski wrote:
> It's not used.
minor nit, you didn't say if you wanted this to go to net or net-next or
add a Fixes: tag?
maybe:
Fixes: e3219ce6a775 ("i40e: Add support for client interface for IWARP
driver")
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
for the patch itself, it looks fine to me, so if you spin this
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> include/linux/net/intel/i40e_client.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/net/intel/i40e_client.h b/include/linux/net/intel/i40e_client.h
> index 6b3267b49755..ed42bd5f639f 100644
> --- a/include/linux/net/intel/i40e_client.h
> +++ b/include/linux/net/intel/i40e_client.h
> @@ -26,11 +26,6 @@ struct i40e_client_version {
> u8 rsvd;
> };
>
> -enum i40e_client_state {
> - __I40E_CLIENT_NULL,
> - __I40E_CLIENT_REGISTERED
> -};
> -
> enum i40e_client_instance_state {
> __I40E_CLIENT_INSTANCE_NONE,
> __I40E_CLIENT_INSTANCE_OPENED,
> @@ -190,11 +185,6 @@ struct i40e_client {
> const struct i40e_client_ops *ops; /* client ops provided by the client */
> };
>
> -static inline bool i40e_client_is_registered(struct i40e_client *client)
> -{
> - return test_bit(__I40E_CLIENT_REGISTERED, &client->state);
> -}
> -
> void i40e_client_device_register(struct i40e_info *ldev, struct i40e_client *client);
> void i40e_client_device_unregister(struct i40e_info *ldev);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i40e: remove enum i40e_client_state
2022-01-26 19:53 ` Jesse Brandeburg
@ 2022-01-26 19:59 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-01-26 19:59 UTC (permalink / raw)
To: Jesse Brandeburg; +Cc: anthony.l.nguyen, shiraz.saleem, netdev, intel-wired-lan
On Wed, 26 Jan 2022 11:53:29 -0800 Jesse Brandeburg wrote:
> On 1/26/2022 10:55 AM, Jakub Kicinski wrote:
> > It's not used.
>
> minor nit, you didn't say if you wanted this to go to net or net-next or
> add a Fixes: tag?
Right, I'm not targeting net or net-next directly. I should have put
something like "intel-next", probably.
> maybe:
> Fixes: e3219ce6a775 ("i40e: Add support for client interface for IWARP
> driver")
>
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> for the patch itself, it looks fine to me, so if you spin this
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Intel-wired-lan] [PATCH] i40e: remove enum i40e_client_state
2022-01-26 18:55 [PATCH] i40e: remove enum i40e_client_state Jakub Kicinski
2022-01-26 19:53 ` Jesse Brandeburg
@ 2022-01-31 5:39 ` G, GurucharanX
1 sibling, 0 replies; 4+ messages in thread
From: G, GurucharanX @ 2022-01-31 5:39 UTC (permalink / raw)
To: Jakub Kicinski, Nguyen, Anthony L
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Saleem, Shiraz
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Jakub Kicinski
> Sent: Thursday, January 27, 2022 12:26 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Saleem, Shiraz
> <shiraz.saleem@intel.com>; Jakub Kicinski <kuba@kernel.org>
> Subject: [Intel-wired-lan] [PATCH] i40e: remove enum i40e_client_state
>
> It's not used.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> include/linux/net/intel/i40e_client.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-31 5:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-26 18:55 [PATCH] i40e: remove enum i40e_client_state Jakub Kicinski
2022-01-26 19:53 ` Jesse Brandeburg
2022-01-26 19:59 ` Jakub Kicinski
2022-01-31 5:39 ` [Intel-wired-lan] " G, GurucharanX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).