From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40310C433F5 for ; Mon, 31 Jan 2022 20:10:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347038AbiAaUKe (ORCPT ); Mon, 31 Jan 2022 15:10:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbiAaUKc (ORCPT ); Mon, 31 Jan 2022 15:10:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5972C061714; Mon, 31 Jan 2022 12:10:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 28BE161483; Mon, 31 Jan 2022 20:10:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CED1C340E8; Mon, 31 Jan 2022 20:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643659831; bh=db3019ER3yHKwYvfr1vDrkC0pSuWFsBGKycjXxPwonk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b0BjUSE02/Lk9W7l6kNn8GCVBmeFqqRvSdMJB07B0CUhVQyPW1NURhoB+dnhBiU+W JBtWhDM36yQbPoBdEN96aO+suz6byn7zIJ6Eq6jO2bocu5K/blX9MyRaU/oaLJB92y FIro4AT9qeG6/0KFZv/ZvSlzM9COMAqqAY9MkSpSUmHGDdcSwzONr1LAsQAXgUAgEo 9wi374x5enP+6A2x50TIBWRdDa34SvB37UqbV2NfGYIcWDP1OykvHH5AlrFFKGZbyU I7Zfogab/rvVHRDnpTn5D9o0mHdsCIV5+zCngZSy+ddRUPNUUW3TOomCt/K7JOMzTc ljRqLy0jmlm9w== Date: Mon, 31 Jan 2022 12:10:27 -0800 From: Jakub Kicinski To: Florian Fainelli Cc: Saeed Mahameed , Geert Uytterhoeven , Stephen Hemminger , Saeed Mahameed , "David S. Miller" , Mark Einon , Lino Sanfilippo , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Chris Snook , Nicolas Ferre , Claudiu Beznea , Hans Ulli Kroll , Linus Walleij , Jeroen de Borst , Catherine Sullivan , David Awogbemila , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , Microchip Linux Driver Support , Jon Mason , Simon Horman , Rain River , Zhu Yanjun , Shannon Nelson , drivers@pensando.io, Sergey Shtylyov , Jiri Pirko , Edward Cree , Martin Habets , Maxime Coquelin , Alexandre Torgue , Jose Abreu , Andy Gospodarek , Michal Simek , Arnd Bergmann , Jacob Keller , Vegard Nossum , Rob Herring , l.stelmach@samsung.com, rafal@milecki.pl, Edwin Peer , Geert Uytterhoeven , Michael Chan , Richard Cochran , Gerhard Engleder , Marcin Wojtas , Oleksij Rempel , Gabriel Somlo , Joel Stanley , Slark Xiao , Christophe Leroy , Liming Sun , David Thompson , Asmaa Mnebhi , Lars Povlsen , Horatiu Vultur , Steen Hegelund , Prabhakar Kushwaha , Omkar Kulkarni , Shai Malin , Randy Dunlap , Vignesh Raghavendra , Stefan Wahren , Gary Guo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, intel-wired-lan@lists.osuosl.org, linux-hyperv@vger.kernel.org, oss-drivers@corigine.com, linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next] net: kbuild: Don't default net vendor configs to y Message-ID: <20220131121027.4fe3e8dc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <30ed8220-e24d-4b40-c7a6-4b09c84f9a1f@gmail.com> References: <20220131172450.4905-1-saeed@kernel.org> <20220131095905.08722670@hermes.local> <20220131183540.6ekn3z7tudy5ocdl@sx1> <30ed8220-e24d-4b40-c7a6-4b09c84f9a1f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 31 Jan 2022 10:40:38 -0800 Florian Fainelli wrote: > >> And changing the defaults means all defconfigs must be updated first, > >> else the user's configs will end up without drivers needed. > >> > > > > As I understand correctly, at least for most common net drivers, having > > NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per > > module for each vendor and those are defaulted to N. > > Right, but once you start hiding NET_VENDOR_DRIVER_XYZ under a > NET_VENDOR_XYZ Kconfig symbol dependency, if NET_VENDOR_XYZ is not set > to Y, then you have no way to select NET_VENDOR_DRIVER_XYZ and so your > old defconfig breaks. To be clear do we actually care about *old* configs or *def* configs? Breaking defconfigs seems bad, but I don't think we can break reasonable oldconfigs at this point? > >> It might make sense to tune some of the defaults (i.e. change to > >> "default y if ARCH_*") for drivers with clear platform dependencies. > >> > > > > either set hard default to 'n' or just keep it as is, anything else is just > > more confusion. > > Maybe the rule should go like this: any new driver vendor defaults to n, > and existing ones remain set to y, until we deprecate doing that and > switching them all off to n by 5.18? I'd be afraid that given the work of fixing up defconfigs is non-trivial we may end up never switching old drivers. And then we'd have a semi-random soup of defaults :(