From: Stefano Brivio <sbrivio@redhat.com>
To: Antoine Tenart <atenart@kernel.org>
Cc: Vlad Buslov <vladbu@nvidia.com>,
davem@davemloft.net, kuba@kernel.org, echaudro@redhat.com,
netdev@vger.kernel.org, pshelar@ovn.org
Subject: Re: [PATCH net 1/2] vxlan: do not modify the shared tunnel info when PMTU triggers an ICMP reply
Date: Mon, 31 Jan 2022 15:04:18 +0100 [thread overview]
Message-ID: <20220131150418.0fabd263@elisabeth> (raw)
In-Reply-To: <164363560725.4133.7633393991691247425@kwain>
Hi Antoine,
On Mon, 31 Jan 2022 14:26:47 +0100
Antoine Tenart <atenart@kernel.org> wrote:
> Quoting Vlad Buslov (2022-01-31 12:26:47)
> > On Fri 28 Jan 2022 at 19:01, Antoine Tenart <atenart@kernel.org> wrote:
> > >
> > > I finally had some time to look at this. Does the diff below fix your
> > > issue?
> >
> > Yes, with the patch applied I'm no longer able to reproduce memory leak.
> > Thanks for fixing this!
>
> Thanks for testing. I'll send a formal patch, can I add your Tested-by?
>
> Also, do you know how to trigger the following code path in OVS
> https://elixir.bootlin.com/linux/latest/source/net/openvswitch/actions.c#L944
I guess the selftests pmtu_ipv{4,6}_ovs_vxlan{4,6}_exception and
pmtu_ipv{4,6}_ovs_geneve{4,6}_exception from net/pmtu.sh:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/net/pmtu.sh?id=ece1278a9b81bdfc088f087f8372a072b7010956#n81
should trigger that path once or twice per test, but I haven't tried
recently.
--
Stefano
next prev parent reply other threads:[~2022-01-31 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 15:35 [PATCH net 0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply Antoine Tenart
2021-03-25 15:35 ` [PATCH net 1/2] vxlan: " Antoine Tenart
2022-01-20 7:38 ` Vlad Buslov
2022-01-20 10:27 ` Antoine Tenart
2022-01-20 12:58 ` Vlad Buslov
2022-01-28 17:01 ` Antoine Tenart
2022-01-31 11:26 ` Vlad Buslov
2022-01-31 13:26 ` Antoine Tenart
2022-01-31 14:04 ` Stefano Brivio [this message]
2022-01-31 14:42 ` Antoine Tenart
2022-01-31 17:55 ` Vlad Buslov
2021-03-25 15:35 ` [PATCH net 2/2] geneve: " Antoine Tenart
2021-03-25 20:28 ` [PATCH net 0/2] net: " Stefano Brivio
2021-03-26 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131150418.0fabd263@elisabeth \
--to=sbrivio@redhat.com \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=echaudro@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).