public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	Varka Bhadram <varkabhadram@gmail.com>,
	Xue Liu <liuxuenetmail@gmail.com>, Alan Ott <alan@signal11.us>
Subject: Re: [PATCH wpan-next v2 5/5] net: ieee802154: Drop duration settings when the core does it already
Date: Tue, 1 Feb 2022 18:40:14 +0100	[thread overview]
Message-ID: <20220201184014.72b3d9a3@xps13> (raw)
In-Reply-To: <20220128110825.1120678-6-miquel.raynal@bootlin.com>

Hi,

> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2978,7 +2978,6 @@ static void ca8210_hw_setup(struct ieee802154_hw *ca8210_hw)
>  	ca8210_hw->phy->cca.mode = NL802154_CCA_ENERGY_CARRIER;
>  	ca8210_hw->phy->cca.opt = NL802154_CCA_OPT_ENERGY_CARRIER_AND;
>  	ca8210_hw->phy->cca_ed_level = -9800;
> -	ca8210_hw->phy->symbol_duration = 16 * NSEC_PER_USEC;
>  	ca8210_hw->phy->lifs_period = 40;
>  	ca8210_hw->phy->sifs_period = 12;

I've missed that error                ^^

This driver should be fixed first (that's probably a copy/paste of the
error from the other driver which did the same).

As the rest of the series will depend on this fix (or conflict) we could
merge it through wpan-next anyway, if you don't mind, as it was there
since 2017 and these numbers had no real impact so far (I believe).

I just figure this out now while searching for leftovers after a rebase
operation, sorry.

Thanks,
Miquèl

  reply	other threads:[~2022-02-01 17:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 11:08 [PATCH wpan-next v2 0/5] ieee802154: Improve durations handling Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 1/5] net: ieee802154: Improve the way supported channels are declared Miquel Raynal
2022-01-30 21:35   ` Alexander Aring
2022-01-31 14:23     ` Miquel Raynal
2022-02-01  0:04       ` Alexander Aring
2022-02-01 14:55         ` Miquel Raynal
2022-02-06 21:37           ` Alexander Aring
2022-02-07  7:49             ` Miquel Raynal
2022-02-20 23:05               ` Alexander Aring
2022-03-02 13:21                 ` Miquel Raynal
2022-03-13 20:58                   ` Alexander Aring
2022-03-18  9:09                     ` Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 2/5] net: ieee802154: Give more details to the core about the channel configurations Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 3/5] net: mac802154: Convert the symbol duration into nanoseconds Miquel Raynal
2022-01-28 13:00   ` Stefan Schmidt
2022-01-28 11:08 ` [PATCH wpan-next v2 4/5] net: mac802154: Set durations automatically Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 5/5] net: ieee802154: Drop duration settings when the core does it already Miquel Raynal
2022-02-01 17:40   ` Miquel Raynal [this message]
2022-02-01 20:51     ` Stefan Schmidt
2022-02-02  7:40       ` Miquel Raynal
2022-02-02 12:17         ` Stefan Schmidt
2022-02-02 13:50           ` Miquel Raynal
2022-02-02 17:07             ` Stefan Schmidt
2022-01-28 11:11 ` [PATCH wpan-next v2 0/5] ieee802154: Improve durations handling Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201184014.72b3d9a3@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=alan@signal11.us \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=liuxuenetmail@gmail.com \
    --cc=michael.hennerich@analog.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox