From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 204E7C433EF for ; Wed, 2 Feb 2022 05:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234575AbiBBFGn (ORCPT ); Wed, 2 Feb 2022 00:06:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbiBBFGe (ORCPT ); Wed, 2 Feb 2022 00:06:34 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B005C061714 for ; Tue, 1 Feb 2022 21:06:34 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E545C6172C for ; Wed, 2 Feb 2022 05:06:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02AEEC340F1; Wed, 2 Feb 2022 05:06:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643778393; bh=W0eFsKlyEJbYFyozN9j4129mBnsyOpQg8zTtEME3GGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=By8mZ5NauBLAUCfvgs00066ep4zFTLHDSf0JBsK/PFHhJEnWVtx+2iUKORMmT5EVb wiZsApm9r16bSk+2yXe2PUKAeaQ7BN0KP5mC1l/oYGjualiviGkflIAX42+gI89Ag0 kyrdHUOFZyJDWj+rdUu90EgSeW9slsfpet0HabbF4JnDn/1jB75M6SwG4KeWv3BtsI tLZa9s8tpo28gkSBSceoLVTKSUoY6BFtmkjyiRf8TdwhCWDZoTnKY1j8GA/jEG79y0 iWdZWX52fYih+NNSoLnoNZTwyu40mOaLb+0mMgL8Nl0lVrCcPC03r1ZNd82iL/S8Zg d1Doj4vc2pdIQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Roi Dayan , Oz Shlomo , Maor Dickman , Saeed Mahameed Subject: [net 03/18] net/mlx5e: TC, Reject rules with drop and modify hdr action Date: Tue, 1 Feb 2022 21:03:49 -0800 Message-Id: <20220202050404.100122-4-saeed@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220202050404.100122-1-saeed@kernel.org> References: <20220202050404.100122-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan This kind of action is not supported by firmware and generates a syndrome. kernel: mlx5_core 0000:08:00.0: mlx5_cmd_check:777:(pid 102063): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x8708c3) Fixes: d7e75a325cb2 ("net/mlx5e: Add offloading of E-Switch TC pedit (header re-write) actions") Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 3d908a7e1406..671f76c350db 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -3191,6 +3191,12 @@ actions_match_supported(struct mlx5e_priv *priv, return false; } + if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR && + actions & MLX5_FLOW_CONTEXT_ACTION_DROP) { + NL_SET_ERR_MSG_MOD(extack, "Drop with modify header action is not supported"); + return false; + } + if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR && !modify_header_match_supported(priv, &parse_attr->spec, flow_action, actions, ct_flow, ct_clear, extack)) -- 2.34.1