* [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command()
@ 2022-02-04 10:03 Dan Carpenter
2022-02-04 17:06 ` Florian Fainelli
2022-02-05 15:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-02-04 10:03 UTC (permalink / raw)
To: Andrew Lunn, Ansuel Smith
Cc: Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, netdev, kernel-janitors
This is a copy and paste bug. It was supposed to check "clear_skb"
instead of "write_skb".
Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/dsa/qca8k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 52ec2800dd89..35bb568b1df5 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -1018,7 +1018,7 @@ qca8k_phy_eth_command(struct qca8k_priv *priv, bool read, int phy,
clear_skb = qca8k_alloc_mdio_header(MDIO_WRITE, QCA8K_MDIO_MASTER_CTRL, &clear_val,
QCA8K_ETHERNET_PHY_PRIORITY, sizeof(clear_val));
- if (!write_skb) {
+ if (!clear_skb) {
ret = -ENOMEM;
goto err_clear_skb;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command()
2022-02-04 10:03 [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command() Dan Carpenter
@ 2022-02-04 17:06 ` Florian Fainelli
2022-02-05 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-02-04 17:06 UTC (permalink / raw)
To: Dan Carpenter, Andrew Lunn, Ansuel Smith
Cc: Vivien Didelot, Vladimir Oltean, David S. Miller, Jakub Kicinski,
netdev, kernel-janitors
On 2/4/2022 2:03 AM, Dan Carpenter wrote:
> This is a copy and paste bug. It was supposed to check "clear_skb"
> instead of "write_skb".
>
> Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command()
2022-02-04 10:03 [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command() Dan Carpenter
2022-02-04 17:06 ` Florian Fainelli
@ 2022-02-05 15:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-05 15:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: andrew, ansuelsmth, vivien.didelot, f.fainelli, olteanv, davem,
kuba, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 4 Feb 2022 13:03:36 +0300 you wrote:
> This is a copy and paste bug. It was supposed to check "clear_skb"
> instead of "write_skb".
>
> Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/dsa/qca8k.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command()
https://git.kernel.org/netdev/net-next/c/c3664d913dc1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-05 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-04 10:03 [PATCH net-next] net: dsa: qca8k: check correct variable in qca8k_phy_eth_command() Dan Carpenter
2022-02-04 17:06 ` Florian Fainelli
2022-02-05 15:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).