From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for stats
Date: Tue, 8 Feb 2022 16:10:32 +0000 [thread overview]
Message-ID: <20220208161031.3jknptcqcc7sltwk@skbuf> (raw)
In-Reply-To: <20220208160742.GB4785@euler>
On Tue, Feb 08, 2022 at 08:07:42AM -0800, Colin Foster wrote:
> # ethtool -S swp1 | head -n 5
> NIC statistics:
> tx_packets: 942
> tx_bytes: 48984
> rx_packets: 764
> rx_bytes: 37808
> # ethtool -S swp2 | head -n 5
> NIC statistics:
> tx_packets: 946
> tx_bytes: 49192
> rx_packets: 1
> rx_bytes: 46
> # ethtool -S swp3 | head -n 5
> NIC statistics:
> tx_packets: 1
> tx_bytes: 52
> rx_packets: 1699
> rx_bytes: 80658
> # ethtool -S swp4 | head -n 5
> NIC statistics:
> tx_packets: 0
> tx_bytes: 0
> rx_packets: 0
> rx_bytes: 0
I understand what confused you now. These are software counters patched
in by dsa_slave_get_ethtool_stats(). They are in no way the counters
from felix_info :: stats_layout, please compare the strings!
next prev parent reply other threads:[~2022-02-08 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 4:46 [PATCH v5 net-next 0/3] use bulk reads for ocelot statistics Colin Foster
2022-02-08 4:46 ` [PATCH v5 net-next 1/3] net: ocelot: align macros for consistency Colin Foster
2022-02-08 13:06 ` Vladimir Oltean
2022-02-08 4:46 ` [PATCH v5 net-next 2/3] net: mscc: ocelot: add ability to perform bulk reads Colin Foster
2022-02-08 13:07 ` Vladimir Oltean
2022-02-08 4:46 ` [PATCH v5 net-next 3/3] net: mscc: ocelot: use bulk reads for stats Colin Foster
2022-02-08 13:18 ` Vladimir Oltean
2022-02-08 15:03 ` Vladimir Oltean
2022-02-08 15:34 ` Vladimir Oltean
2022-02-08 16:07 ` Colin Foster
2022-02-08 16:10 ` Vladimir Oltean [this message]
2022-02-08 15:41 ` Colin Foster
2022-02-08 15:45 ` Vladimir Oltean
2022-02-08 16:49 ` Colin Foster
2022-02-08 17:02 ` Vladimir Oltean
2022-02-08 13:30 ` [PATCH v5 net-next 0/3] use bulk reads for ocelot statistics Vladimir Oltean
2022-02-08 13:55 ` Colin Foster
2022-02-08 14:53 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220208161031.3jknptcqcc7sltwk@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox