Re: [v5] dsa: mv88e6xxx: make serdes SGMII/Fiber tx amplitude configurable

["Marek Behún" <kabel@kernel.org>]

On Wed, 9 Feb 2022 15:04:56 +0000
Holger Brunck <holger.brunck@hitachienergy.com> wrote:

> > > +     if (chip->info->ops->serdes_set_tx_p2p_amplitude) {
> > > +             dp = dsa_to_port(ds, port);
> > > +             if (dp)
> > > +                     phy_handle = of_parse_phandle(dp->dn, "phy-handle", 0);
> > > +
> > > +             if (phy_handle && !of_property_read_u32(phy_handle,
> > > +                                                     "tx-p2p-microvolt",
> > > +                                                     &tx_amp)) {
> > > +                     err = mv88e6352_serdes_set_tx_p2p_amplitude(chip, port,
> > > +                                                                 tx_amp);
> > > +                     if (err) {
> > > +                             of_node_put(phy_handle);
> > > +                             return err;
> > > +                     }  
> > 
> > You could move this test
> >   
> > > +             }
> > > +             if (phy_handle)
> > > +                     of_node_put(phy_handle);  
> > 
> > to here, since you need to put the phy_handle anyway.
> >   
> 
> ok. I think I will also rename the ...set_tx_p2p_amplitude to ...set_tx_p2p to
> shorten the function names. Makes it easier to read.

Please don't drop "amplitude". If anything, drop the "p2p".

Marek