From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590B4C4332F for ; Thu, 10 Feb 2022 21:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344562AbiBJVQc (ORCPT ); Thu, 10 Feb 2022 16:16:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344554AbiBJVQa (ORCPT ); Thu, 10 Feb 2022 16:16:30 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4EFC1120 for ; Thu, 10 Feb 2022 13:16:29 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id t36so1706639pfg.0 for ; Thu, 10 Feb 2022 13:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=56GxMSeC38DM7FjFScYhpGTuLwbWHwsMqi8kcAas7E4=; b=FDKenY6uG8aNafmFX+Zg+YrB5T4Ep6A1O3Fde4Ag43f5AMMXe9HR0HtDP4Ih0HvH+3 SY41Qh0xwpNOR/NKw3xSVKjSRjB+SuAm+0uZpPu/J95DLbAkevEwN9+41pCKemI61p5a Rp1jHJIJqVsRIOYArqyB/pwspLyKPK1IeTWXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=56GxMSeC38DM7FjFScYhpGTuLwbWHwsMqi8kcAas7E4=; b=N/loocy41+P/pFiMEmKANycuKljCMVmtqJ24ePTSBSbNPhPYt946xL6xe3+6X4eDeN nVyKFWsdWXIMI+KjSyqPZ9AfQyIMv0yDOIbP45/J4Afjrq8TjFPpwx15VVY1Nbc6IMhD ZhNghxAjYmrLbFaa3cqxsFf9Fr2ELULuYCC007mKtrulV9WYNAKHcFimqCE1r4btRwS8 VDkNY9//3Rkz91M87P/wdr1p0A+lm34ob03onLcxkCuxVUkT3XPZ4GwNowGozeEJ5vX1 F6S6WXWKYJG4/6HrZXPJqm3UWqs9j/9KCNp8jcTvkiN/buVXnCvCOrgw/6LwxDCJT2EQ 8oIg== X-Gm-Message-State: AOAM533MSr/xGeV7e5+Iw8WZVfnlscZ80LnKe/zAySKPC7fcuCdtxaiI qtpAdWw2RzkubhwIQJ7vA1Z7JG428Ha/1w== X-Google-Smtp-Source: ABdhPJyEIEonG5UDKp6DdoNJBTiX1KgMJI7EkGIooEaffcNz/EsNH1tDm2q31M5y0fyxN0XpV0Gylw== X-Received: by 2002:a63:da0b:: with SMTP id c11mr7643183pgh.436.1644527789466; Thu, 10 Feb 2022 13:16:29 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r11sm23537151pff.81.2022.02.10.13.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 13:16:29 -0800 (PST) Date: Thu, 10 Feb 2022 13:16:28 -0800 From: Kees Cook To: Sherry Yang Cc: skhan@linuxfoundation.org, shuah@kernel.org, luto@amacapital.net, wad@chromium.org, christian@brauner.io, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Message-ID: <202202101316.E38FEAFBCA@keescook> References: <20220210203049.67249-1-sherry.yang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210203049.67249-1-sherry.yang@oracle.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 10, 2022 at 12:30:49PM -0800, Sherry Yang wrote: > seccomp_bpf failed on tests 47 global.user_notification_filter_empty > and 48 global.user_notification_filter_empty_threaded when it's > tested on updated kernel but with old kernel headers. Because old > kernel headers don't have definition of macro __NR_clone3 which is > required for these two tests. Since under selftests/, we can install > headers once for all tests (the default INSTALL_HDR_PATH is > usr/include), fix it by adding usr/include to the list of directories > to be searched. Use "-isystem" to indicate it's a system directory as > the real kernel headers directories are. > > Signed-off-by: Sherry Yang Thanks! Reviewed-by: Kees Cook -- Kees Cook