From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3BC9C433EF for ; Tue, 15 Feb 2022 08:17:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234908AbiBOIRM (ORCPT ); Tue, 15 Feb 2022 03:17:12 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233692AbiBOIRL (ORCPT ); Tue, 15 Feb 2022 03:17:11 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50095811AB for ; Tue, 15 Feb 2022 00:17:02 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJt0w-0004Wb-Ba; Tue, 15 Feb 2022 09:16:46 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nJt0v-0000QV-3a; Tue, 15 Feb 2022 09:16:45 +0100 Date: Tue, 15 Feb 2022 09:16:45 +0100 From: Oleksij Rempel To: Marc Kleine-Budde Cc: Tony Lindgren , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, Jakub Kicinski , devicetree@vger.kernel.org, Nicolas Saenz Julienne , =?utf-8?Q?Beno=C3=AEt?= Cousson , Ray Jui , Sascha Hauer , Rob Herring , linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Florian Fainelli , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Scott Branden , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Shawn Guo , "David S. Miller" Subject: Re: [PATCH v3 5/8] ARM: dts: exynos: fix ethernet node name for different odroid boards Message-ID: <20220215081645.GD672@pengutronix.de> References: <20220215080937.2263111-1-o.rempel@pengutronix.de> <20220215080937.2263111-5-o.rempel@pengutronix.de> <20220215081240.hhie4niqnc5tuka2@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220215081240.hhie4niqnc5tuka2@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:13:37 up 66 days, 16:59, 71 users, load average: 0.06, 0.15, 0.16 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 15, 2022 at 09:12:40AM +0100, Marc Kleine-Budde wrote: > On 15.02.2022 09:09:34, Oleksij Rempel wrote: > > The node name of Ethernet controller should be "ethernet" instead of > > "usbether" > > > > Signed-off-by: Oleksij Rempel > > --- > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 4 ++-- > > arch/arm/boot/dts/exynos4412-odroidx.dts | 8 ++++---- > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 4 ++-- > > arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 6 +++--- > > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 6 +++--- > > 5 files changed, 14 insertions(+), 14 deletions(-) > > > > diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts > > index efaf7533e84f..36c369c42b77 100644 > > --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts > > +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts > > @@ -119,8 +119,8 @@ &ehci { > > phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>; > > phy-names = "hsic0", "hsic1"; > > > > - ethernet: usbether@2 { > > - compatible = "usb0424,9730"; > > + ethernet: ethernet@2 { > > + compatible = "usb424,9730"; > > The change of the compatible is not mentioned in the patch description. > Is this intentional? No, I forgot to mentione it. According to the USB schema 0 should be removed. So, this compatible was incorrect as well. With leading zero present yaml schema was not able to detect and validate this node. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |