netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Nikolay Aleksandrov <nikolay@nvidia.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Roopa Prabhu <roopa@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Rafael Richter <rafael.richter@gin.de>,
	Daniel Klauer <daniel.klauer@gin.de>,
	Tobias Waldekranz <tobias@waldekranz.com>
Subject: Re: [PATCH v3 net-next 03/11] net: bridge: vlan: make __vlan_add_flags react only to PVID and UNTAGGED
Date: Wed, 16 Feb 2022 11:08:45 +0000	[thread overview]
Message-ID: <20220216110845.4vu2bcsuez5jhvn6@skbuf> (raw)
In-Reply-To: <79237e2d-e1d2-c6cd-975d-b28f064a2c20@nvidia.com>

On Wed, Feb 16, 2022 at 01:03:54PM +0200, Nikolay Aleksandrov wrote:
> This patch is unnecessary and can be dropped given the next one.

Not unnecessary, it reduces the complexity of the next change and makes
for a cleaner transformation of __vlan_add_flags(), one that doesn't
affect its commit behavior. The behavior change will matter for patch 4.

  parent reply	other threads:[~2022-02-16 11:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 17:02 [PATCH v3 net-next 00/11] Replay and offload host VLAN entries in DSA Vladimir Oltean
2022-02-15 17:02 ` [PATCH v3 net-next 01/11] net: bridge: vlan: check early for lack of BRENTRY flag in br_vlan_add_existing Vladimir Oltean
2022-02-16 10:58   ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 02/11] net: bridge: vlan: don't notify to switchdev master VLANs without BRENTRY flag Vladimir Oltean
2022-02-16 11:00   ` Nikolay Aleksandrov
2022-02-16 11:10     ` Vladimir Oltean
2022-02-16 11:11       ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 03/11] net: bridge: vlan: make __vlan_add_flags react only to PVID and UNTAGGED Vladimir Oltean
2022-02-16 11:03   ` Nikolay Aleksandrov
2022-02-16 11:07     ` Nikolay Aleksandrov
2022-02-16 11:08     ` Vladimir Oltean [this message]
2022-02-16 11:22       ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 04/11] net: bridge: vlan: notify switchdev only when something changed Vladimir Oltean
2022-02-16 11:25   ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 05/11] net: bridge: switchdev: differentiate new VLANs from changed ones Vladimir Oltean
2022-02-16 11:27   ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 06/11] net: bridge: make nbp_switchdev_unsync_objs() follow reverse order of sync() Vladimir Oltean
2022-02-16 11:34   ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 07/11] net: bridge: switchdev: replay all VLAN groups Vladimir Oltean
2022-02-16 11:38   ` Nikolay Aleksandrov
2022-02-15 17:02 ` [PATCH v3 net-next 08/11] net: switchdev: rename switchdev_lower_dev_find to switchdev_lower_dev_find_rcu Vladimir Oltean
2022-02-15 17:02 ` [PATCH v3 net-next 09/11] net: switchdev: introduce switchdev_handle_port_obj_{add,del} for foreign interfaces Vladimir Oltean
2022-02-15 17:02 ` [PATCH v3 net-next 10/11] net: dsa: add explicit support for host bridge VLANs Vladimir Oltean
2022-02-15 17:02 ` [PATCH v3 net-next 11/11] net: dsa: offload bridge port VLANs on foreign interfaces Vladimir Oltean
2022-02-16 16:01 ` [PATCH v3 net-next 00/11] Replay and offload host VLAN entries in DSA Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220216110845.4vu2bcsuez5jhvn6@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=daniel.klauer@gin.de \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=idosch@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=olteanv@gmail.com \
    --cc=rafael.richter@gin.de \
    --cc=roopa@nvidia.com \
    --cc=tobias@waldekranz.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).