From: Vladimir Oltean <olteanv@gmail.com>
To: "Måns Rullgård" <mans@mansr.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org,
Egil Hjelmeland <privat@egil-hjelmeland.no>,
Andrew Lunn <andrew@lunn.ch>,
Juergen Borleis <jbe@pengutronix.de>,
Grygorii Strashko <grygorii.strashko@ti.com>,
lorenzo@kernel.org
Subject: Re: DSA using cpsw and lan9303
Date: Wed, 16 Feb 2022 16:15:43 +0200 [thread overview]
Message-ID: <20220216141543.dnrnuvei4zck6xts@skbuf> (raw)
In-Reply-To: <yw1xa6er2bno.fsf@mansr.com>
On Wed, Feb 16, 2022 at 01:17:47PM +0000, Måns Rullgård wrote:
> > Some complaints about accessing the CPU port as dsa_to_port(chip->ds, 0),
> > but it's not the first place in this driver where that is done.
>
> What would be the proper way to do it?
Generally speaking:
struct dsa_port *cpu_dp;
dsa_switch_for_each_cpu_port(cpu_dp, ds)
break;
// use cpu_dp
If your code runs after dsa_tree_setup_default_cpu(), which contains the
"DSA: tree %d has no CPU port\n" check, you don't even need to check
whether cpu_dp was found or not - it surely was. Everything that runs
after dsa_register_switch() has completed successfully - for example the
DSA ->setup() method - qualifies here.
next prev parent reply other threads:[~2022-02-16 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 16:44 DSA using cpsw and lan9303 Måns Rullgård
2022-02-14 17:16 ` Florian Fainelli
2022-02-14 17:43 ` Vladimir Oltean
2022-02-14 19:17 ` Måns Rullgård
2022-02-15 20:54 ` Vladimir Oltean
2022-02-16 13:17 ` Måns Rullgård
2022-02-16 14:15 ` Vladimir Oltean [this message]
2022-02-16 14:23 ` Måns Rullgård
2022-02-16 14:26 ` Vladimir Oltean
2022-02-16 17:00 ` Vladimir Oltean
2022-02-16 17:47 ` Måns Rullgård
2022-02-16 17:55 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216141543.dnrnuvei4zck6xts@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=jbe@pengutronix.de \
--cc=lorenzo@kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=privat@egil-hjelmeland.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox