From: Dan Carpenter <dan.carpenter@oracle.com>
To: "David S. Miller" <davem@davemloft.net>,
Joseph CHAMG <josright123@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH net-next] net: dm9051: Fix use after free in dm9051_loop_tx()
Date: Fri, 18 Feb 2022 18:27:30 +0300 [thread overview]
Message-ID: <20220218152730.GA4299@kili> (raw)
This code dereferences "skb" after calling dev_kfree_skb().
Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/davicom/dm9051.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c
index a63d17e669a0..f6b5d2becf5e 100644
--- a/drivers/net/ethernet/davicom/dm9051.c
+++ b/drivers/net/ethernet/davicom/dm9051.c
@@ -850,13 +850,13 @@ static int dm9051_loop_tx(struct board_info *db)
if (skb) {
ntx++;
ret = dm9051_single_tx(db, skb->data, skb->len);
+ ndev->stats.tx_bytes += skb->len;
+ ndev->stats.tx_packets++;
dev_kfree_skb(skb);
if (ret < 0) {
db->bc.tx_err_counter++;
return 0;
}
- ndev->stats.tx_bytes += skb->len;
- ndev->stats.tx_packets++;
}
if (netif_queue_stopped(ndev) &&
--
2.20.1
next reply other threads:[~2022-02-18 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 15:27 Dan Carpenter [this message]
2022-02-19 5:07 ` [PATCH net-next] net: dm9051: Fix use after free in dm9051_loop_tx() Jakub Kicinski
2022-02-21 10:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218152730.GA4299@kili \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=josright123@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).