From: Vladimir Oltean <olteanv@gmail.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Ansuel Smith <ansuelsmth@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next v2 1/6] net: dsa: add support for phylink mac_select_pcs()
Date: Sat, 19 Feb 2022 23:22:24 +0200 [thread overview]
Message-ID: <20220219212223.efd2mfxmdokvaosq@skbuf> (raw)
In-Reply-To: <20220219211241.beyajbwmuz7fg2bt@skbuf>
On Sat, Feb 19, 2022 at 11:12:41PM +0200, Vladimir Oltean wrote:
> > static const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
> > .validate = dsa_port_phylink_validate,
> > + .mac_select_pcs = dsa_port_phylink_mac_select_pcs,
>
> This patch breaks probing on DSA switch drivers that weren't converted
> to supported_interfaces, due to this check in phylink_create():
And this is only the most superficial layer of breakage. Everywhere in
phylink.c where pl->mac_ops->mac_select_pcs() is used, its presence is
checked and non-zero return codes from it are treated as hard errors,
even -EOPNOTSUPP, even if this particular error code is probably
intended to behave identically as the absence of the function pointer,
for compatibility.
next prev parent reply other threads:[~2022-02-19 21:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 18:29 [PATCH net-next v2 0/6] net: dsa: qca8k: convert to phylink_pcs and mark as non-legacy Russell King (Oracle)
2022-02-17 18:30 ` [PATCH net-next v2 1/6] net: dsa: add support for phylink mac_select_pcs() Russell King (Oracle)
2022-02-19 21:12 ` Vladimir Oltean
2022-02-19 21:22 ` Vladimir Oltean [this message]
2022-02-21 13:30 ` Russell King (Oracle)
2022-02-21 14:15 ` Russell King (Oracle)
2022-02-21 14:41 ` Vladimir Oltean
2022-02-21 14:32 ` Vladimir Oltean
2022-02-21 14:44 ` Russell King (Oracle)
2022-02-21 14:55 ` Vladimir Oltean
2022-02-21 16:38 ` Russell King (Oracle)
2022-02-17 18:30 ` [PATCH net-next v2 2/6] net: dsa: qca8k: move qca8k_setup() Russell King (Oracle)
2022-02-17 18:30 ` [PATCH net-next v2 3/6] net: dsa: qca8k: move qca8k_phylink_mac_link_state() Russell King (Oracle)
2022-02-17 18:30 ` [PATCH net-next v2 4/6] net: dsa: qca8k: convert to use phylink_pcs Russell King (Oracle)
2022-02-17 18:30 ` [PATCH net-next v2 5/6] net: dsa: qca8k: move pcs configuration Russell King (Oracle)
2022-02-17 18:31 ` [PATCH net-next v2 6/6] net: dsa: qca8k: mark as non-legacy Russell King (Oracle)
2022-02-18 11:50 ` [PATCH net-next v2 0/6] net: dsa: qca8k: convert to phylink_pcs and " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220219212223.efd2mfxmdokvaosq@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox