From: Stephen Hemminger <stephen@networkplumber.org>
To: Geliang Tang <geliang.tang@suse.com>
Cc: David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
Mat Martineau <mathew.j.martineau@linux.intel.com>
Subject: Re: [PATCH iproute2-next v2 1/3] mptcp: add fullmesh check for adding address
Date: Tue, 22 Feb 2022 19:08:59 -0800 [thread overview]
Message-ID: <20220222190859.4b79cbf4@hermes.local> (raw)
In-Reply-To: <295a693ecc4ec1c3c241db0999d97d8718b7d992.1645584573.git.geliang.tang@suse.com>
On Wed, 23 Feb 2022 10:59:47 +0800
Geliang Tang <geliang.tang@suse.com> wrote:
> + if (adding &&
> + (flags & MPTCP_PM_ADDR_FLAG_SIGNAL) &&
> + (flags & MPTCP_PM_ADDR_FLAG_FULLMESH))
> + invarg("invalid flags\n", *argv)
There is a duplicate newline here, the message already gets newline from invarg().
If possible could you give explanation to the user.
Looks like mptcp has this in lots of places, and would be helpful
to give better response.
next prev parent reply other threads:[~2022-02-23 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 2:59 [PATCH iproute2-next v2 0/3] mptcp: add the fullmesh flag setting support Geliang Tang
2022-02-23 2:59 ` [PATCH iproute2-next v2 1/3] mptcp: add fullmesh check for adding address Geliang Tang
2022-02-23 3:08 ` Stephen Hemminger [this message]
2022-02-23 2:59 ` [PATCH iproute2-next v2 2/3] mptcp: add fullmesh support for setting flags Geliang Tang
2022-02-23 2:59 ` [PATCH iproute2-next v2 3/3] mptcp: add port " Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222190859.4b79cbf4@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=geliang.tang@suse.com \
--cc=mathew.j.martineau@linux.intel.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).