Re: [PATCH RFC net-next v2 01/10] net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()

[Vladimir Oltean <olteanv@gmail.com>]

Hello,

On Wed, Feb 23, 2022 at 11:34:17AM +0000, Russell King (Oracle) wrote:
> Discussing one of the tests in mt753x_phylink_validate() with Landen
> Chao confirms that the "||" should be "&&". Fix this.
> 
> Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/net/dsa/mt7530.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index f74f25f479ed..69abca77ea1a 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -2936,7 +2936,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
>  
>  	phylink_set_port_modes(mask);
>  
> -	if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
> +	if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
>  	    !phy_interface_mode_is_8023z(state->interface)) {
>  		phylink_set(mask, 10baseT_Half);
>  		phylink_set(mask, 10baseT_Full);
> -- 
> 2.30.2
> 

Since the "net" pull request for this week is scheduled to happen rather
soon, I think you should split this and send it to "net", so that you
won't have to wait when you resend as non-RFC.