From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7412AC433F5 for ; Thu, 24 Feb 2022 00:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245183AbiBXAM7 (ORCPT ); Wed, 23 Feb 2022 19:12:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245182AbiBXAMw (ORCPT ); Wed, 23 Feb 2022 19:12:52 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B4E5F8C0 for ; Wed, 23 Feb 2022 16:12:23 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 13532B8228B for ; Thu, 24 Feb 2022 00:12:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61EAEC340F5; Thu, 24 Feb 2022 00:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645661542; bh=5HlVWd8sdoBmV6RaN5F0WJ8X6P9zT60QHBI3eEFAqnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQJef1gmr7Wf7E+sHXo3i9lHfaUoo4Ave3CqhoyOo999q3hSHSGapoPOX5PJsY40i 9ushdfzNgHffsfKD/Pir4T6Y8pG6AJ5ARUw81vKsBbqieYwrk3V46TXrq1oHcz1I8H kstKiTCH158k2jjHyAqdrObU+aneKEiyw6QgESmFQ0B8nWWi7vTU/BeslqtDkXp6lD 7caGnBZO4yLMk6YOhlLVetaJpzc4FmWErotuQ/wpW7Jbx3e5YnN8l8a2ASZNZaroVC 5c3GPsbzEk1D0M1z0DXxWj+4bHbjzgbnorW8AaRnseTlsG7msY6nkUBIxO1bn/L9NL bdP49Qzass7XQ== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Gal Pressman , Tariq Toukan , Saeed Mahameed Subject: [v2 net 10/19] net/mlx5e: Fix wrong return value on ioctl EEPROM query failure Date: Wed, 23 Feb 2022 16:11:14 -0800 Message-Id: <20220224001123.365265-11-saeed@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220224001123.365265-1-saeed@kernel.org> References: <20220224001123.365265-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Gal Pressman The ioctl EEPROM query wrongly returns success on read failures, fix that by returning the appropriate error code. Fixes: bb64143eee8c ("net/mlx5e: Add ethtool support for dump module EEPROM") Signed-off-by: Gal Pressman Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index 57d755db1cf5..6e80585d731f 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -1792,7 +1792,7 @@ static int mlx5e_get_module_eeprom(struct net_device *netdev, if (size_read < 0) { netdev_err(priv->netdev, "%s: mlx5_query_eeprom failed:0x%x\n", __func__, size_read); - return 0; + return size_read; } i += size_read; -- 2.35.1