* [PATCH] net/mlx5e: TC, Fix use after free in mlx5e_clone_flow_attr_for_post_act()
@ 2022-02-24 14:53 Dan Carpenter
2022-02-25 12:18 ` Roi Dayan
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2022-02-24 14:53 UTC (permalink / raw)
To: Saeed Mahameed, Roi Dayan
Cc: Leon Romanovsky, netdev, linux-rdma, kernel-janitors
This returns freed memory leading to a use after free. It's supposed to
return NULL.
Fixes: 8300f225268b ("net/mlx5e: Create new flow attr for multi table actions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This goes through Saeed's tree not the net tree.
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 76a015dfc5fc..c0776a4a3845 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -3398,7 +3398,7 @@ mlx5e_clone_flow_attr_for_post_act(struct mlx5_flow_attr *attr,
if (!attr2 || !parse_attr) {
kvfree(parse_attr);
kfree(attr2);
- return attr2;
+ return NULL;
}
memcpy(attr2, attr, attr_sz);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net/mlx5e: TC, Fix use after free in mlx5e_clone_flow_attr_for_post_act()
2022-02-24 14:53 [PATCH] net/mlx5e: TC, Fix use after free in mlx5e_clone_flow_attr_for_post_act() Dan Carpenter
@ 2022-02-25 12:18 ` Roi Dayan
2022-03-01 7:16 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Roi Dayan @ 2022-02-25 12:18 UTC (permalink / raw)
To: Dan Carpenter, Saeed Mahameed
Cc: Leon Romanovsky, netdev, linux-rdma, kernel-janitors
On 2022-02-24 4:53 PM, Dan Carpenter wrote:
> This returns freed memory leading to a use after free. It's supposed to
> return NULL.
>
> Fixes: 8300f225268b ("net/mlx5e: Create new flow attr for multi table actions")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This goes through Saeed's tree not the net tree.
>
> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> index 76a015dfc5fc..c0776a4a3845 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> @@ -3398,7 +3398,7 @@ mlx5e_clone_flow_attr_for_post_act(struct mlx5_flow_attr *attr,
> if (!attr2 || !parse_attr) {
> kvfree(parse_attr);
> kfree(attr2);
> - return attr2;
> + return NULL;
> }
>
> memcpy(attr2, attr, attr_sz);
hi, I noticed your fix now and already reviewed same fix from Colin
https://patchwork.kernel.org/project/netdevbpf/patch/20220224221525.147744-1-colin.i.king@gmail.com/
so just need to take either one.
thanks
Reviewed-by: Roi Dayan <roid@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net/mlx5e: TC, Fix use after free in mlx5e_clone_flow_attr_for_post_act()
2022-02-25 12:18 ` Roi Dayan
@ 2022-03-01 7:16 ` Saeed Mahameed
0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2022-03-01 7:16 UTC (permalink / raw)
To: Roi Dayan
Cc: Dan Carpenter, Saeed Mahameed, Leon Romanovsky, netdev,
linux-rdma, kernel-janitors
On 25 Feb 14:18, Roi Dayan wrote:
>
>
>On 2022-02-24 4:53 PM, Dan Carpenter wrote:
>>This returns freed memory leading to a use after free. It's supposed to
>>return NULL.
>>
>>Fixes: 8300f225268b ("net/mlx5e: Create new flow attr for multi table actions")
>>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>---
>>This goes through Saeed's tree not the net tree.
>>
>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
>>index 76a015dfc5fc..c0776a4a3845 100644
>>--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
>>+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
>>@@ -3398,7 +3398,7 @@ mlx5e_clone_flow_attr_for_post_act(struct mlx5_flow_attr *attr,
>> if (!attr2 || !parse_attr) {
>> kvfree(parse_attr);
>> kfree(attr2);
>>- return attr2;
>>+ return NULL;
>> }
>> memcpy(attr2, attr, attr_sz);
>
>hi, I noticed your fix now and already reviewed same fix from Colin
>
>https://patchwork.kernel.org/project/netdevbpf/patch/20220224221525.147744-1-colin.i.king@gmail.com/
>
>so just need to take either one.
>thanks
>
Ok this one arrived first, will take this one :).
applied to net-next-mlx5.
>Reviewed-by: Roi Dayan <roid@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-01 7:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-24 14:53 [PATCH] net/mlx5e: TC, Fix use after free in mlx5e_clone_flow_attr_for_post_act() Dan Carpenter
2022-02-25 12:18 ` Roi Dayan
2022-03-01 7:16 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).