From: Vladimir Oltean <olteanv@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>,
kernel@pengutronix.de, Jakub Kicinski <kuba@kernel.org>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v2 1/1] net: dsa: microchip: ksz9477: implement MTU configuration
Date: Fri, 25 Feb 2022 18:35:43 +0200 [thread overview]
Message-ID: <20220225163543.vnqlkltgmwf4vlmm@skbuf> (raw)
In-Reply-To: <20220225125430.GB27407@pengutronix.de>
On Fri, Feb 25, 2022 at 01:54:30PM +0100, Oleksij Rempel wrote:
> > No bridge, why create a bridge? And even if you do, why add lan5 to it?
> > The expectation is that standalone ports still remain functional when
> > other ports join a bridge.
>
> No, lan5 is not added to the bridge, but stops functioning after creating
> br with lan1 or any other lanX
Please take time to investigate the problem and fix it.
> > I was saying:
> >
> > ip link set lan1 up
> > ip link add link lan1 name lan1.5 type vlan id 5
> > ip addr add 172.17.0.2/24 dev lan1.5 && ip link set lan1.5 up
> > iperf3 -c 172.17.0.10
>
> It works.
This is akin to saying that without any calls to ksz9477_change_mtu(),
just writing VLAN_ETH_FRAME_LEN + ETH_FCS_LEN into REG_SW_MTU__2 is
sufficient to get VLAN-tagged MTU-sized packets to pass through the CPU
port and the lan1 user port.
So my question is: is this necessary?
if (dsa_is_cpu_port(ds, port))
new_mtu += KSZ9477_INGRESS_TAG_LEN;
next prev parent reply other threads:[~2022-02-25 16:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 8:40 [PATCH net-next v2 1/1] net: dsa: microchip: ksz9477: implement MTU configuration Oleksij Rempel
2022-02-23 23:38 ` Vladimir Oltean
2022-02-24 4:59 ` Oleksij Rempel
2022-02-24 9:33 ` Vladimir Oltean
2022-02-24 9:38 ` Oleksij Rempel
2022-02-24 9:46 ` Vladimir Oltean
2022-02-25 11:47 ` Oleksij Rempel
2022-02-25 11:58 ` Vladimir Oltean
2022-02-25 12:54 ` Oleksij Rempel
2022-02-25 16:35 ` Vladimir Oltean [this message]
2022-03-08 10:06 ` Oleksij Rempel
2022-03-08 11:21 ` Vladimir Oltean
2022-03-08 11:59 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225163543.vnqlkltgmwf4vlmm@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox