From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0AA9C433FE for ; Sat, 26 Feb 2022 02:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbiBZCYB (ORCPT ); Fri, 25 Feb 2022 21:24:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbiBZCYA (ORCPT ); Fri, 25 Feb 2022 21:24:00 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64F5E1CABDE for ; Fri, 25 Feb 2022 18:23:27 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id w2so6235230pfu.11 for ; Fri, 25 Feb 2022 18:23:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f0XyVRsy6VI+7eRXJAPqPSb00XdxH7dw8UKaExj76WY=; b=GbbdOdzubH9OeXiGvJCqbZANneBAor10rlDy64UkWrUddr6ky6pTk20qwBTntYhEbs zqPvVzlCk9wq2RGLlGlCgYYvieOosw5pCn0kDFQYlW9iHMYXvb58O/p+g6S/JX2kkVSM 1He00hlo1YNX4NuSvLTHqFpdFrRtPOFiM9TlA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f0XyVRsy6VI+7eRXJAPqPSb00XdxH7dw8UKaExj76WY=; b=ZHdY2HnVbh3P4fc0AFpMkoEQJSrNG8WXcvDa6noS46IytgEVLJLuJ6+ciWrzwXZYWj IgRHcw/4OrXwlVA3kqMChJSBEZ4Su2lBh+4ng2Ko4oYJzJvDwPkP6DayGW0w2/Dr7i8/ qIgF0jnHRfIFR9doL5Es7NUzoz+RVnssqMOn0KnDbpi8VP1hKaYNGhcCHmenJRK8QpV4 1wwHnw0zSBAcpbiqI8jY+Ov313bOPN/UEfxuGxdhbetGJ4v1iShPRzGEIldniROOmvmv mCQFePxVdKvz+yVvcwbucHBYP4wMGKmEj0xp10pTHmNB4GhNt7aEtrZ9ynSQ19/gS+nx pyzg== X-Gm-Message-State: AOAM532I2dLafM0Yd62IRdqYUy7fdnwogt2bD5JdJ/ndgE5YUHS5T0sQ BugwSrvhLpQjdXr3Cxb43LYq5Q== X-Google-Smtp-Source: ABdhPJyGHey3mOCBptss5gAziA/MSrAvAK5hKHAs1C85u6b/2KXCUrd4ZfmYqJyFhOM+4DuxoD5d2g== X-Received: by 2002:aa7:9429:0:b0:4e1:5814:79b3 with SMTP id y9-20020aa79429000000b004e1581479b3mr10582289pfo.82.1645842206911; Fri, 25 Feb 2022 18:23:26 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 131-20020a621989000000b004df51429f31sm4914239pfz.79.2022.02.25.18.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Feb 2022 18:23:26 -0800 (PST) Date: Fri, 25 Feb 2022 18:23:26 -0800 From: Kees Cook To: Shuah Khan Cc: Muhammad Usama Anjum , Shuah Khan , Eric Biederman , Paolo Bonzini , "David S. Miller" , Jakub Kicinski , kernel@collabora.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] kselftest: add generated objects to .gitignore Message-ID: <202202251823.138A87C@keescook> References: <20220225102726.3231228-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 25, 2022 at 04:59:58PM -0700, Shuah Khan wrote: > On 2/25/22 3:27 AM, Muhammad Usama Anjum wrote: > > Add kselftests_install directory and some other files to the > > .gitignore. > > > > Signed-off-by: Muhammad Usama Anjum > > --- > > tools/testing/selftests/.gitignore | 1 + > > tools/testing/selftests/exec/.gitignore | 2 ++ > > tools/testing/selftests/kvm/.gitignore | 1 + > > tools/testing/selftests/net/.gitignore | 1 + > > 4 files changed, 5 insertions(+) > > > > It is better to split these patches per test - makes it easier > to apply. Please send separate patches for each test. This patch > doesn't apply as is. Once fixed, please consider them: Reviewed-by: Kees Cook -- Kees Cook