From: Vladimir Oltean <olteanv@gmail.com>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: Luiz Angelo Daros de Luca <luizluca@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"arinc.unal@arinc9.com" <arinc.unal@arinc9.com>
Subject: Re: [PATCH net-next v4 2/3] net: dsa: tag_rtl8_4: add rtl8_4t trailing variant
Date: Mon, 28 Feb 2022 17:22:21 +0200 [thread overview]
Message-ID: <20220228152221.t4hpni66hav2ockb@skbuf> (raw)
In-Reply-To: <87zgmbb34o.fsf@bang-olufsen.dk>
On Mon, Feb 28, 2022 at 12:13:28PM +0000, Alvin Šipraga wrote:
> Luiz Angelo Daros de Luca <luizluca@gmail.com> writes:
>
> > Realtek switches supports the same tag both before ethertype or between
> > payload and the CRC.
> >
> > Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
>
> Hi Luiz,
>
> Please note that you should normally put my Reviewed-by after your
> S-o-b. After your v1 (and assuming you remembered your S-o-b) it should
> be treated as append-only. Gives some chronology to the review process.
I don't know if this is a hard and fast rule, but it is also how I do
things, and how b4 applies the tags as well. But I've seen people do
otherwise too.
next prev parent reply other threads:[~2022-02-28 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 3:59 [PATCH net-next v4 0/2] net: dsa: realtek: add rtl8_4t tag Luiz Angelo Daros de Luca
2022-02-27 3:59 ` [PATCH net-next v4 1/3] dt-bindings: net: dsa: add rtl8_4 and rtl8_4t Luiz Angelo Daros de Luca
2022-02-28 12:51 ` Vladimir Oltean
2022-02-27 3:59 ` [PATCH net-next v4 2/3] net: dsa: tag_rtl8_4: add rtl8_4t trailing variant Luiz Angelo Daros de Luca
2022-02-28 12:13 ` Alvin Šipraga
2022-02-28 15:22 ` Vladimir Oltean [this message]
2022-02-28 14:50 ` Vladimir Oltean
2022-02-27 3:59 ` [PATCH net-next v4 3/3] net: dsa: realtek: rtl8365mb: add support for rtl8_4t Luiz Angelo Daros de Luca
2022-02-28 14:52 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228152221.t4hpni66hav2ockb@skbuf \
--to=olteanv@gmail.com \
--cc=ALSI@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox