From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Yang Li <yang.lee@linux.alibaba.com>,
Joseph CHAMG <josright123@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dm9051: Make remove() callback a void function
Date: Tue, 1 Mar 2022 08:26:01 +1100 [thread overview]
Message-ID: <20220301082601.24f09172@canb.auug.org.au> (raw)
In-Reply-To: <20220228114913.209d141b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
Hi Jakub,
On Mon, 28 Feb 2022 11:49:13 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 28 Feb 2022 17:39:57 +0000 Mark Brown wrote:
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> >
> > Changes introduced since the merge window in the spi subsystem and
> > available at:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-remove-void
> >
> > make the remove() callback for spi return void rather than int, breaking
> > the newly added dm9051 driver fail to build. This patch fixes this
> > issue, converting the remove() function provided by the driver to return
> > void.
> >
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > [Rewrote commit message -- broonie]
> > Signed-off-by: Mark Brown <broonie@kernel.org>
>
> Pulled & applied, thanks!
For future reference, that patch of mine should have been applied as
part of the merge commit that brought in the topic branch.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-28 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 17:39 [PATCH] net: dm9051: Make remove() callback a void function Mark Brown
2022-02-28 17:39 ` Mark Brown
2022-02-28 19:49 ` Jakub Kicinski
2022-02-28 21:26 ` Stephen Rothwell [this message]
2022-02-28 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301082601.24f09172@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=josright123@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox