netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan - ML <linux-wpan@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	Varka Bhadram <varkabhadram@gmail.com>,
	Xue Liu <liuxuenetmail@gmail.com>, Alan Ott <alan@signal11.us>
Subject: Re: [PATCH wpan-next v2 1/5] net: ieee802154: Improve the way supported channels are declared
Date: Wed, 2 Mar 2022 14:21:38 +0100	[thread overview]
Message-ID: <20220302142138.4122b3c6@xps13> (raw)
In-Reply-To: <CAB_54W6RC9dqRzPyN3OYb6pWfst+UixSAKppaCtDaCvzE0_kAQ@mail.gmail.com>

Hi Alexander,

alex.aring@gmail.com wrote on Sun, 20 Feb 2022 18:05:39 -0500:

> Hi,
> 
> On Mon, Feb 7, 2022 at 2:49 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Alexander,
> >
> > alex.aring@gmail.com wrote on Sun, 6 Feb 2022 16:37:23 -0500:
> >  
> > > Hi,
> > >
> > > On Tue, Feb 1, 2022 at 9:55 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > ...  
> > > >
> > > > Given the new information that I am currently processing, I believe the
> > > > array is not needed anymore, we can live with a minimal number of
> > > > additional helpers, like the one getting the PRF value for the UWB
> > > > PHYs. It's the only one I have in mind so far.  
> > >
> > > I am not really sure if I understood now. So far those channel/page
> > > combinations are the same because we have no special "type" value in
> > > wpan_phy,  
> >
> > Yes, my assumption was more: I know there are only -legacy- phy types
> > supported, we will add another (or improve the current) way of defining
> > channels when we'll need to. Eg when improving UWB support.
> >  
> > > what we currently support is the "normal" (I think they name
> > > it legacy devices) phy type (no UWB, sun phy, whatever) and as Channel
> > > Assignments says that it does not apply for those PHY's I think it
> > > there are channel/page combinations which are different according to
> > > the PHY "type". However we don't support them and I think there might
> > > be an upcoming type field in wpan_phy which might be set only once at
> > > registration time.  
> >
> > An idea might be to create a callback that drivers might decide to
> > implement or not. If they implement it, the core might call it to get
> > further information about the channels. The core would provide a {page,
> > channel} couple and retrieve a structure with many information such as
> > the the frequency, the protocol, eventually the prf, etc.
> >  
> 
> As I said before, for "many information" we should look at how
> wireless is using that with regdb and extend it with 802.15.4
> channels/etc. The kernel should only deal with an unique
> identification of a database key for "regdb" which so far I see is a
> combination of phy type, page id and channel id. Then from "somewhere"
> also the country code gets involved into that and you get a subset of
> what is available.

Do you want another implementation of regdb that would support the
802.15.4 world only (so far it is highly 802.11 oriented) ? Or is this
something that you would like to merge in the existing project?

Overall it can be useful to define what is allowed in different
countries but this will not save us from needing extra information from
the devices. Describing the channels and protocols (and PRFs) for an
UWB PHY has nothing to do with the regulatory database, it's just
listing what is supported by the device. The actual location where it
might be useful to have a regdb (but not mandatory at the beginning)
would be when changing channels to avoid messing with local
regulations, I believe?

Thanks,
Miquèl

  reply	other threads:[~2022-03-02 13:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 11:08 [PATCH wpan-next v2 0/5] ieee802154: Improve durations handling Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 1/5] net: ieee802154: Improve the way supported channels are declared Miquel Raynal
2022-01-30 21:35   ` Alexander Aring
2022-01-31 14:23     ` Miquel Raynal
2022-02-01  0:04       ` Alexander Aring
2022-02-01 14:55         ` Miquel Raynal
2022-02-06 21:37           ` Alexander Aring
2022-02-07  7:49             ` Miquel Raynal
2022-02-20 23:05               ` Alexander Aring
2022-03-02 13:21                 ` Miquel Raynal [this message]
2022-03-13 20:58                   ` Alexander Aring
2022-03-18  9:09                     ` Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 2/5] net: ieee802154: Give more details to the core about the channel configurations Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 3/5] net: mac802154: Convert the symbol duration into nanoseconds Miquel Raynal
2022-01-28 13:00   ` Stefan Schmidt
2022-01-28 11:08 ` [PATCH wpan-next v2 4/5] net: mac802154: Set durations automatically Miquel Raynal
2022-01-28 11:08 ` [PATCH wpan-next v2 5/5] net: ieee802154: Drop duration settings when the core does it already Miquel Raynal
2022-02-01 17:40   ` Miquel Raynal
2022-02-01 20:51     ` Stefan Schmidt
2022-02-02  7:40       ` Miquel Raynal
2022-02-02 12:17         ` Stefan Schmidt
2022-02-02 13:50           ` Miquel Raynal
2022-02-02 17:07             ` Stefan Schmidt
2022-01-28 11:11 ` [PATCH wpan-next v2 0/5] ieee802154: Improve durations handling Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220302142138.4122b3c6@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=alan@signal11.us \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=liuxuenetmail@gmail.com \
    --cc=michael.hennerich@analog.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).