netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Coco Li <lixiaoyan@google.com>, David Ahern <dsahern@kernel.org>,
	Alexander Duyck <alexanderduyck@fb.com>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH v2 net-next 08/14] ipv6: Add hop-by-hop header to jumbograms in ip6_output
Date: Thu,  3 Mar 2022 10:16:01 -0800	[thread overview]
Message-ID: <20220303181607.1094358-9-eric.dumazet@gmail.com> (raw)
In-Reply-To: <20220303181607.1094358-1-eric.dumazet@gmail.com>

From: Coco Li <lixiaoyan@google.com>

Instead of simply forcing a 0 payload_len in IPv6 header,
implement RFC 2675 and insert a custom extension header.

Note that only TCP stack is currently potentially generating
jumbograms, and that this extension header is purely local,
it wont be sent on a physical link.

This is needed so that packet capture (tcpdump and friends)
can properly dissect these large packets.

Signed-off-by: Coco Li <lixiaoyan@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 include/linux/ipv6.h  |  1 +
 net/ipv6/ip6_output.c | 22 ++++++++++++++++++++--
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/include/linux/ipv6.h b/include/linux/ipv6.h
index 16870f86c74d3d1f5dfb7edac1e7db85f1ef6755..93b273db1c9926aba4199f486ce90778311916f5 100644
--- a/include/linux/ipv6.h
+++ b/include/linux/ipv6.h
@@ -144,6 +144,7 @@ struct inet6_skb_parm {
 #define IP6SKB_L3SLAVE         64
 #define IP6SKB_JUMBOGRAM      128
 #define IP6SKB_SEG6	      256
+#define IP6SKB_FAKEJUMBO      512
 };
 
 #if defined(CONFIG_NET_L3_MASTER_DEV)
diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 50db9b20d746bc59c7ef7114492db8b9585c575b..38a8e1c9894cd99ecbec5968fcc97549ea0c7508 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -180,7 +180,9 @@ static int __ip6_finish_output(struct net *net, struct sock *sk, struct sk_buff
 #endif
 
 	mtu = ip6_skb_dst_mtu(skb);
-	if (skb_is_gso(skb) && !skb_gso_validate_network_len(skb, mtu))
+	if (skb_is_gso(skb) &&
+	    !(IP6CB(skb)->flags & IP6SKB_FAKEJUMBO) &&
+	    !skb_gso_validate_network_len(skb, mtu))
 		return ip6_finish_output_gso_slowpath_drop(net, sk, skb, mtu);
 
 	if ((skb->len > mtu && !skb_is_gso(skb)) ||
@@ -251,6 +253,8 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
 	struct dst_entry *dst = skb_dst(skb);
 	struct net_device *dev = dst->dev;
 	struct inet6_dev *idev = ip6_dst_idev(dst);
+	struct hop_jumbo_hdr *hop_jumbo;
+	int hoplen = sizeof(*hop_jumbo);
 	unsigned int head_room;
 	struct ipv6hdr *hdr;
 	u8  proto = fl6->flowi6_proto;
@@ -258,7 +262,7 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
 	int hlimit = -1;
 	u32 mtu;
 
-	head_room = sizeof(struct ipv6hdr) + LL_RESERVED_SPACE(dev);
+	head_room = sizeof(struct ipv6hdr) + hoplen + LL_RESERVED_SPACE(dev);
 	if (opt)
 		head_room += opt->opt_nflen + opt->opt_flen;
 
@@ -281,6 +285,20 @@ int ip6_xmit(const struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
 					     &fl6->saddr);
 	}
 
+	if (unlikely(seg_len > IPV6_MAXPLEN)) {
+		hop_jumbo = skb_push(skb, hoplen);
+
+		hop_jumbo->nexthdr = proto;
+		hop_jumbo->hdrlen = 0;
+		hop_jumbo->tlv_type = IPV6_TLV_JUMBO;
+		hop_jumbo->tlv_len = 4;
+		hop_jumbo->jumbo_payload_len = htonl(seg_len + hoplen);
+
+		proto = IPPROTO_HOPOPTS;
+		seg_len = 0;
+		IP6CB(skb)->flags |= IP6SKB_FAKEJUMBO;
+	}
+
 	skb_push(skb, sizeof(struct ipv6hdr));
 	skb_reset_network_header(skb);
 	hdr = ipv6_hdr(skb);
-- 
2.35.1.616.g0bdcbb4464-goog


  parent reply	other threads:[~2022-03-03 18:16 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03 18:15 [PATCH v2 net-next 00/14] tcp: BIG TCP implementation Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 01/14] net: add netdev->tso_ipv6_max_size attribute Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 02/14] ipv6: add dev->gso_ipv6_max_size Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 03/14] tcp_cubic: make hystart_ack_delay() aware of BIG TCP Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 04/14] ipv6: add struct hop_jumbo_hdr definition Eric Dumazet
2022-03-04 19:26   ` Alexander H Duyck
2022-03-04 19:28     ` Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 05/14] ipv6/gso: remove temporary HBH/jumbo header Eric Dumazet
2022-03-03 18:15 ` [PATCH v2 net-next 06/14] ipv6/gro: insert " Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 07/14] ipv6: add GRO_IPV6_MAX_SIZE Eric Dumazet
2022-03-04  4:37   ` David Ahern
2022-03-04 17:16     ` Eric Dumazet
2022-03-03 18:16 ` Eric Dumazet [this message]
2022-03-04  4:33   ` [PATCH v2 net-next 08/14] ipv6: Add hop-by-hop header to jumbograms in ip6_output David Ahern
2022-03-04 15:48     ` Alexander H Duyck
2022-03-04 17:09       ` Eric Dumazet
2022-03-04 19:00         ` Alexander H Duyck
2022-03-04 19:13           ` Eric Dumazet
2022-03-05 16:53             ` David Ahern
2022-03-04 17:47     ` Eric Dumazet
2022-03-05 16:46       ` David Ahern
2022-03-05 18:08         ` Eric Dumazet
2022-03-05 19:06           ` David Ahern
2022-03-05 16:55   ` David Ahern
2022-03-03 18:16 ` [PATCH v2 net-next 09/14] net: loopback: enable BIG TCP packets Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 10/14] bonding: update dev->tso_ipv6_max_size Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 11/14] macvlan: enable BIG TCP Packets Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 12/14] ipvlan: " Eric Dumazet
2022-03-03 18:16 ` [PATCH v2 net-next 13/14] mlx4: support BIG TCP packets Eric Dumazet
2022-03-08 16:03   ` Tariq Toukan
2022-03-03 18:16 ` [PATCH v2 net-next 14/14] mlx5: " Eric Dumazet
2022-03-04  4:42   ` David Ahern
2022-03-04 17:14     ` Eric Dumazet
2022-03-05 16:36       ` David Ahern
2022-03-05 17:57         ` Eric Dumazet
2022-03-08 16:02   ` Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220303181607.1094358-9-eric.dumazet@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=alexanderduyck@fb.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).