From: Vladimir Oltean <olteanv@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH v2 net-next] net: dsa: unlock the rtnl_mutex when dsa_master_setup() fails
Date: Sat, 5 Mar 2022 14:32:34 +0200 [thread overview]
Message-ID: <20220305123234.z7dotdedlqdsokj6@skbuf> (raw)
In-Reply-To: <20220304205659.5e0c6997@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Mar 04, 2022 at 08:56:59PM -0800, Jakub Kicinski wrote:
> On Thu, 3 Mar 2022 16:08:40 +0200 Vladimir Oltean wrote:
> > Subject: [PATCH v2 net-next] net: dsa: unlock the rtnl_mutex when dsa_master_setup() fails
>
> Did you mean s/-next//?
I really meant net-next, but now I see that I was wrong.
What I did was:
git tag --contains c146f9bc195a
v5.17-rc1
v5.17-rc2
v5.17-rc3
v5.17-rc4
v5.17-rc5
v5.17-rc6
and from this I drew the incorrect conclusion that the patch was merged
during the v5.17 rc's, for inclusion in v5.18.
>
> > After the blamed commit, dsa_tree_setup_master() may exit without
> > calling rtnl_unlock(), fix that.
> >
> > Fixes: c146f9bc195a ("net: dsa: hold rtnl_mutex when calling dsa_master_{setup,teardown}")
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > ---
> > v1->v2: actually propagate the error code instead of always returning 0
next prev parent reply other threads:[~2022-03-05 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 14:08 [PATCH v2 net-next] net: dsa: unlock the rtnl_mutex when dsa_master_setup() fails Vladimir Oltean
2022-03-05 4:56 ` Jakub Kicinski
2022-03-05 12:32 ` Vladimir Oltean [this message]
2022-03-07 21:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220305123234.z7dotdedlqdsokj6@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox