From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44360C4332F for ; Mon, 7 Mar 2022 02:59:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234907AbiCGDAW (ORCPT ); Sun, 6 Mar 2022 22:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234906AbiCGDAU (ORCPT ); Sun, 6 Mar 2022 22:00:20 -0500 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4E3EDFAF; Sun, 6 Mar 2022 18:59:25 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R771e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=dust.li@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0V6OHzgx_1646621961; Received: from localhost(mailfrom:dust.li@linux.alibaba.com fp:SMTPD_---0V6OHzgx_1646621961) by smtp.aliyun-inc.com(127.0.0.1); Mon, 07 Mar 2022 10:59:22 +0800 Date: Mon, 7 Mar 2022 10:59:21 +0800 From: "dust.li" To: Randy Dunlap , Karsten Graul , Tony Lu , davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next v3] net/smc: fix compile warning for smc_sysctl Message-ID: <20220307025921.GE35207@linux.alibaba.com> Reply-To: dust.li@linux.alibaba.com References: <20220307015424.59154-1-dust.li@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 06, 2022 at 06:36:35PM -0800, Randy Dunlap wrote: > > >On 3/6/22 17:54, Dust Li wrote: >> kernel test robot reports multiple warning for smc_sysctl: > >when SYSCTL is not enabled >(AFAIK) Right. CONFIG_SMC=m|y and CONFIG_SYSCTL is not enabled. > >> In file included from net/smc/smc_sysctl.c:17: >>>> net/smc/smc_sysctl.h:23:5: warning: no previous prototype \ >> for function 'smc_sysctl_init' [-Wmissing-prototypes] >> int smc_sysctl_init(void) >> ^ >> and >> >> WARNING: modpost: vmlinux.o(.text+0x12ced2d): Section mismatch \ >> in reference from the function smc_sysctl_exit() to the variable >> .init.data:smc_sysctl_ops >> The function smc_sysctl_exit() references >> the variable __initdata smc_sysctl_ops. >> This is often because smc_sysctl_exit lacks a __initdata >> annotation or the annotation of smc_sysctl_ops is wrong. >> >> and >> net/smc/smc_sysctl.c: In function 'smc_sysctl_init_net': >> net/smc/smc_sysctl.c:47:17: error: 'struct netns_smc' has no member named 'smc_hdr' >> 47 | net->smc.smc_hdr = register_net_sysctl(net, "net/smc", table); >> >> Since we don't need global sysctl initialization. To make things >> clean and simple, remove the global pernet_operations and >> smc_sysctl_{init|exit}. Call smc_sysctl_net_{init|exit} directly >> from smc_net_{init|exit}. >> >> Also initialized sysctl_autocorking_size if CONFIG_SYSCTL it not >> set, this make sure SMC autocorking is enabled by default if >> CONFIG_SYSCTL is not set. >> >> Fixes: 462791bbfa35 ("net/smc: add sysctl interface for SMC") >> Reported-by: kernel test robot >> Signed-off-by: Dust Li >> >> --- >> v3: 1. add __net_{init|exit} annotation for smc_sysctl_net_{init|exit} >> sugguested by Jakub Kicinski >> 2. Remove static inline for smc_sysctl_net_{init|exit} if >> CONFIG_SYSCTL not defined >> v2: 1. Removes pernet_operations and smc_sysctl_{init|exit} >> 2. Initialize sysctl_autocorking_size if CONFIG_SYSCTL not set >> --- >> net/smc/Makefile | 3 ++- >> net/smc/af_smc.c | 15 ++++++--------- >> net/smc/smc_sysctl.c | 19 ++----------------- >> net/smc/smc_sysctl.h | 9 +++++---- >> 4 files changed, 15 insertions(+), 31 deletions(-) > >Tested-by: Randy Dunlap # build-tested Thanks a lot for testing ! > >thanks. > >-- >~Randy