From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Roopa Prabhu <roopa@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] vxlan_core: delete unnecessary condition
Date: Mon, 7 Mar 2022 17:15:52 +0300 [thread overview]
Message-ID: <20220307141552.GC3315@kadam> (raw)
In-Reply-To: <c568979a-d3da-c577-840f-ca6689f7400f@blackwall.org>
On Mon, Mar 07, 2022 at 03:05:49PM +0200, Nikolay Aleksandrov wrote:
> On 07/03/2022 14:57, Dan Carpenter wrote:
> > The previous check handled the "if (!nh)" condition so we know "nh"
> > is non-NULL here. Delete the check and pull the code in one tab.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > This not a bug so a Fixes tag is innappropriate, however for reviewers
> > this was introduced in commit 4095e0e1328a ("drivers: vxlan: vnifilter:
> > per vni stats")
>
> No, it was not introduced by that commit.
> It was introduced by commit:
> 1274e1cc4226 ("vxlan: ecmp support for mac fdb entries")
Yeah. Sorry. No idea how I got that wrong.
regards,
dan carpenter
next prev parent reply other threads:[~2022-03-07 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 12:57 [PATCH net-next] vxlan_core: delete unnecessary condition Dan Carpenter
2022-03-07 13:05 ` Nikolay Aleksandrov
2022-03-07 13:07 ` Nikolay Aleksandrov
2022-03-08 3:46 ` Roopa Prabhu
2022-03-07 14:15 ` Dan Carpenter [this message]
2022-03-08 6:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220307141552.GC3315@kadam \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).