* [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name
@ 2022-03-09 2:27 Luiz Angelo Daros de Luca
2022-03-09 3:19 ` Florian Fainelli
2022-03-09 6:03 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-03-09 2:27 UTC (permalink / raw)
To: netdev
Cc: linus.walleij, andrew, vivien.didelot, f.fainelli, olteanv, davem,
kuba, alsi, arinc.unal, Luiz Angelo Daros de Luca
DSA_TAG_PROTO_RTL8_4L is not defined. It should be
DSA_TAG_PROTO_RTL8_4T.
Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
net/dsa/tag_rtl8_4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/tag_rtl8_4.c b/net/dsa/tag_rtl8_4.c
index 71fec45fd0ea..a593ead7ff26 100644
--- a/net/dsa/tag_rtl8_4.c
+++ b/net/dsa/tag_rtl8_4.c
@@ -247,7 +247,7 @@ static const struct dsa_device_ops rtl8_4t_netdev_ops = {
DSA_TAG_DRIVER(rtl8_4t_netdev_ops);
-MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4L);
+MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_RTL8_4T);
static struct dsa_tag_driver *dsa_tag_drivers[] = {
&DSA_TAG_DRIVER_NAME(rtl8_4_netdev_ops),
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name
2022-03-09 2:27 [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name Luiz Angelo Daros de Luca
@ 2022-03-09 3:19 ` Florian Fainelli
2022-03-09 6:03 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2022-03-09 3:19 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca, netdev
Cc: linus.walleij, andrew, vivien.didelot, olteanv, davem, kuba, alsi,
arinc.unal
On 3/8/2022 6:27 PM, Luiz Angelo Daros de Luca wrote:
> DSA_TAG_PROTO_RTL8_4L is not defined. It should be
> DSA_TAG_PROTO_RTL8_4T.
>
> Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
> Reported-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name
2022-03-09 2:27 [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name Luiz Angelo Daros de Luca
2022-03-09 3:19 ` Florian Fainelli
@ 2022-03-09 6:03 ` Jakub Kicinski
2022-03-09 17:31 ` Luiz Angelo Daros de Luca
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-03-09 6:03 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: netdev, linus.walleij, andrew, vivien.didelot, f.fainelli,
olteanv, davem, alsi, arinc.unal
On Tue, 8 Mar 2022 23:27:58 -0300 Luiz Angelo Daros de Luca wrote:
> DSA_TAG_PROTO_RTL8_4L is not defined. It should be
> DSA_TAG_PROTO_RTL8_4T.
>
> Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
This SHA does not exist upstream.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name
2022-03-09 6:03 ` Jakub Kicinski
@ 2022-03-09 17:31 ` Luiz Angelo Daros de Luca
0 siblings, 0 replies; 4+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-03-09 17:31 UTC (permalink / raw)
To: Jakub Kicinski
Cc: open list:NETWORKING DRIVERS, Linus Walleij, Andrew Lunn,
Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Alvin Šipraga, Arınç ÜNAL
> > Fixes: 7c33ef0ad83d ("net: dsa: tag_rtl8_4: add rtl8_4t trailing variant")
>
> This SHA does not exist upstream.
Sorry, I got it from a backport branch. I'll send v3. Thanks for the review.
Regards,
Luiz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-09 17:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-09 2:27 [PATCH net-next v2] net: dsa: tag_rtl8_4: fix typo in modalias name Luiz Angelo Daros de Luca
2022-03-09 3:19 ` Florian Fainelli
2022-03-09 6:03 ` Jakub Kicinski
2022-03-09 17:31 ` Luiz Angelo Daros de Luca
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).