From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31053C433F5 for ; Wed, 9 Mar 2022 16:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236586AbiCIQgM (ORCPT ); Wed, 9 Mar 2022 11:36:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237681AbiCIQbE (ORCPT ); Wed, 9 Mar 2022 11:31:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D696918DAAD; Wed, 9 Mar 2022 08:24:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D0BF6195B; Wed, 9 Mar 2022 16:24:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C11CFC340EC; Wed, 9 Mar 2022 16:24:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646843075; bh=W2DYh/V6ODjkXeMpzuzD5sehvu38aMyPEf4Kpt2YQJI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QUj88SXRx8ZsLAGLMtENGLSlZ0pMUVgKvNtVK2WNcvV4ew2hYciOHVPLALCds+urr 0+4/VpIkmTnx0HLtQ/BpfhfGIsK1V3sxolDf66CAiomSOsO13xmUbMiO5aXMMG964a m0KHLhAMxYvzIooY4hbH7W297BTUfBg2eC0y46OX2Q2IkKQeZdawb23xc8qSB14xFB vqOSF//dmF1VHFrV2AWzQ+rhH5ZnNSYrZ16EDvlsMC8o/6HgDyyURd2kR1+8aeWGtg b+05jyWgXgy74jbFRYy0yYSViyEvf/MtkPvaOEx3iTUgjJniO1mxMhqoPGHeX3RNJx 63/TqWuIlTFKg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jia-Ju Bai , TOTE Robot , "David S . Miller" , Sasha Levin , 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 12/19] atm: firestream: check the return value of ioremap() in fs_init() Date: Wed, 9 Mar 2022 11:23:29 -0500 Message-Id: <20220309162337.136773-12-sashal@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220309162337.136773-1-sashal@kernel.org> References: <20220309162337.136773-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jia-Ju Bai [ Upstream commit d4e26aaea7f82ba884dcb4acfe689406bc092dc3 ] The function ioremap() in fs_init() can fail, so its return value should be checked. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/atm/firestream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/firestream.c b/drivers/atm/firestream.c index 5acb45985675..8995c39330fa 100644 --- a/drivers/atm/firestream.c +++ b/drivers/atm/firestream.c @@ -1677,6 +1677,8 @@ static int fs_init(struct fs_dev *dev) dev->hw_base = pci_resource_start(pci_dev, 0); dev->base = ioremap(dev->hw_base, 0x1000); + if (!dev->base) + return 1; reset_chip (dev); -- 2.34.1