* [PATCH net-next] tcp: fix build problem in tcp_inbound_md5_hash()
@ 2022-03-09 16:28 Jakub Kicinski
2022-03-09 16:40 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2022-03-09 16:28 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, Jakub Kicinski
Semicolon snuck in, this breaks the build with CONFIG_TCP_MD5SIG=n.
Fixes: 4be98688274d ("skb: make drop reason booleanable")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
include/net/tcp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
index ee8237b58e1d..70ca4a5e330a 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1693,7 +1693,7 @@ tcp_md5_do_lookup(const struct sock *sk, int l3index,
static inline enum skb_drop_reason
tcp_inbound_md5_hash(const struct sock *sk, const struct sk_buff *skb,
const void *saddr, const void *daddr,
- int family, int dif, int sdif);
+ int family, int dif, int sdif)
{
return SKB_NOT_DROPPED_YET;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] tcp: fix build problem in tcp_inbound_md5_hash()
2022-03-09 16:28 [PATCH net-next] tcp: fix build problem in tcp_inbound_md5_hash() Jakub Kicinski
@ 2022-03-09 16:40 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2022-03-09 16:40 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: David Miller, netdev
On Wed, Mar 9, 2022 at 8:28 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Semicolon snuck in, this breaks the build with CONFIG_TCP_MD5SIG=n.
>
> Fixes: 4be98688274d ("skb: make drop reason booleanable")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
>
Vladimir Oltean sent the fix earlier this morning.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-09 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-09 16:28 [PATCH net-next] tcp: fix build problem in tcp_inbound_md5_hash() Jakub Kicinski
2022-03-09 16:40 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).