From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586D4C433F5 for ; Wed, 9 Mar 2022 21:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234833AbiCIVjG (ORCPT ); Wed, 9 Mar 2022 16:39:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231797AbiCIVjF (ORCPT ); Wed, 9 Mar 2022 16:39:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4079A6D944 for ; Wed, 9 Mar 2022 13:38:06 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEB7661B0D for ; Wed, 9 Mar 2022 21:38:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEAB5C340EC; Wed, 9 Mar 2022 21:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646861885; bh=gvrovV5AbgeMbvQIuUpkTKfRH+1xowEtCWXuHmyRC50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iNsh4Raze4AI933HJwHrhb99cH9NDzGSgEcKVFYjWOnIkrR1u9miwgXIwXX+9Oakx b4UZBnsEOK1OWNetbHbi9sYwWNzAAgsezNT+2bAvaJq6V0epqBgAevtnP/+XT6KJeP gIaZ+PacGyyL4ODQ/qBG4W5Baev6+/zzS24375Z5g3WAYsosuQYtPksgInlF7umSvc VXVmRdGV3zK9WkP//kfWy3jxmkhurbIUf9uwlFn1DVp21yCczyrbrH45R2VR3u0WBu 4B2qX2Uera82ZEjp5ysbdzuPl+Z84xGEfQ88HsCvIVOCfzZoXlXPt6WEdPop1obag0 YnoT7orzbs4JA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Dan Carpenter , Roi Dayan , Saeed Mahameed Subject: [net-next 01/16] net/mlx5e: TC, Fix use after free in mlx5e_clone_flow_attr_for_post_act() Date: Wed, 9 Mar 2022 13:37:40 -0800 Message-Id: <20220309213755.610202-2-saeed@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220309213755.610202-1-saeed@kernel.org> References: <20220309213755.610202-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter This returns freed memory leading to a use after free. It's supposed to return NULL. Fixes: 8300f225268b ("net/mlx5e: Create new flow attr for multi table actions") Signed-off-by: Dan Carpenter Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 40416e0a8bb1..e3fc15ae7bb1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -3410,7 +3410,7 @@ mlx5e_clone_flow_attr_for_post_act(struct mlx5_flow_attr *attr, if (!attr2 || !parse_attr) { kvfree(parse_attr); kfree(attr2); - return attr2; + return NULL; } memcpy(attr2, attr, attr_sz); -- 2.35.1