From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ulrich Hecht <uli+renesas@fpond.eu>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-can@vger.kernel.org, "Lad,
Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Wolfram Sang <wsa@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Jakub Kicinski <kuba@kernel.org>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
socketcan@hartkopp.net,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH v4 0/4] can: rcar_canfd: Add support for V3U flavor
Date: Thu, 10 Mar 2022 09:50:09 +0100 [thread overview]
Message-ID: <20220310085009.nmefzy26ysas4omw@pengutronix.de> (raw)
In-Reply-To: <CAMuHMdVoEm+0MZS-wMChS45YfPamfnBdM0CH5Rv-F_C4uAx0Kw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]
On 10.03.2022 09:45:50, Geert Uytterhoeven wrote:
> Hi Marc,
>
> On Thu, Mar 10, 2022 at 9:26 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > On 09.03.2022 17:26:05, Ulrich Hecht wrote:
> > > This adds CANFD support for V3U (R8A779A0) SoCs. The V3U's IP supports up
> > > to eight channels and has some other minor differences to the Gen3 variety:
> > >
> > > - changes to some register offsets and layouts
> > > - absence of "classic CAN" registers, both modes are handled through the
> > > CANFD register set
> > >
> > > This patch set tries to accommodate these changes in a minimally intrusive
> > > way.
> > >
> > > This revision tries to address the remaining style issues raised by
> > > reviewers. Thanks to Vincent, Marc and Simon for their reviews and
> > > suggestions.
> > >
> > > It has been successfully tested remotely on a V3U Falcon board, but only
> > > with channels 0 and 1. We were not able to get higher channels to work in
> > > both directions yet. It is not currently clear if this is an issue with the
> > > driver, the board or the silicon, but the BSP vendor driver only works with
> > > channels 0 and 1 as well, so my bet is on one of the latter. For this
> > > reason, this series only enables known-working channels 0 and 1 on Falcon.
> >
> > Should I take the whole series via linux-can/next?
>
> Please don't take the DTS changes.
Ok, I'm taking the yaml update and the driver changes.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-03-10 8:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 16:26 [PATCH v4 0/4] can: rcar_canfd: Add support for V3U flavor Ulrich Hecht
2022-03-09 16:26 ` [PATCH v4 1/4] can: rcar_canfd: Add support for r8a779a0 SoC Ulrich Hecht
2022-03-10 1:14 ` Vincent MAILHOL
2022-03-09 16:26 ` [PATCH v4 2/4] arm64: dts: renesas: r8a779a0: Add CANFD device node Ulrich Hecht
2022-03-11 17:04 ` Geert Uytterhoeven
2022-03-09 16:26 ` [PATCH v4 3/4] arm64: dts: renesas: r8a779a0-falcon: enable CANFD 0 and 1 Ulrich Hecht
2022-03-11 17:04 ` Geert Uytterhoeven
2022-03-14 8:04 ` Geert Uytterhoeven
2022-03-09 16:26 ` [PATCH v4 4/4] dt-bindings: can: renesas,rcar-canfd: Document r8a779a0 support Ulrich Hecht
2022-03-10 8:25 ` [PATCH v4 0/4] can: rcar_canfd: Add support for V3U flavor Marc Kleine-Budde
2022-03-10 8:32 ` Ulrich Hecht
2022-03-10 8:45 ` Geert Uytterhoeven
2022-03-10 8:50 ` Marc Kleine-Budde [this message]
2022-03-11 4:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310085009.nmefzy26ysas4omw@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kieran.bingham@ideasonboard.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=socketcan@hartkopp.net \
--cc=uli+renesas@fpond.eu \
--cc=wg@grandegger.com \
--cc=wsa@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).