From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C44AC433F5 for ; Fri, 11 Mar 2022 07:13:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242653AbiCKHO2 (ORCPT ); Fri, 11 Mar 2022 02:14:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233144AbiCKHO1 (ORCPT ); Fri, 11 Mar 2022 02:14:27 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D4C7F463D; Thu, 10 Mar 2022 23:13:24 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id CFAAF68AFE; Fri, 11 Mar 2022 08:13:19 +0100 (CET) Date: Fri, 11 Mar 2022 08:13:19 +0100 From: Christoph Hellwig To: Mingbao Sun Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Eric Dumazet , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , netdev@vger.kernel.org, tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com, libin.zhang@dell.com, ao.sun@dell.com Subject: Re: [PATCH 1/3] tcp: export symbol tcp_set_congestion_control Message-ID: <20220311071319.GA18222@lst.de> References: <20220311030113.73384-1-sunmingbao@tom.com> <20220311030113.73384-2-sunmingbao@tom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220311030113.73384-2-sunmingbao@tom.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Maybe add a kerneldoc comment now that this is an exported API? Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig