From: Mingbao Sun <sunmingbao@tom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com,
libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH] tcp: export symbol tcp_set_congestion_control
Date: Fri, 11 Mar 2022 09:29:16 +0800 [thread overview]
Message-ID: <20220311092916.00005266@tom.com> (raw)
In-Reply-To: <20220310124825.159ce624@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, 10 Mar 2022 12:48:25 -0800
Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 10 Mar 2022 21:48:30 +0800 Mingbao Sun wrote:
> > Since the kernel API 'kernel_setsockopt' was removed, and since the
> > function ‘tcp_set_congestion_control’ is just the real underlying guy
> > handling this job, so it makes sense to get it exported.
>
> Do you happen to have a reference to the commit which removed
> kernel_setsockopt and the justification? My knee jerk reaction
> would the that's a better path than allowing in-kernel socket users
> to poke at internal functions even if that works as of today.
FYI
(Sorry for putting URLs in the mail):
kernel_setsockopt disappeared from kernel v5.8,
and all the relevant users have switched to
dedicated small functions.
The mail thread:
https://lists.archive.carbon60.com/linux/kernel/3712394
The commit:
https://github.com/torvalds/linux/commit/5a892ff2facb4548c17c05931ed899038a0da63e
next prev parent reply other threads:[~2022-03-11 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 13:48 [PATCH] tcp: export symbol tcp_set_congestion_control Mingbao Sun
2022-03-10 14:11 ` Christoph Hellwig
2022-03-10 15:03 ` Mingbao Sun
2022-03-10 15:05 ` Christoph Hellwig
2022-03-10 20:48 ` Jakub Kicinski
2022-03-11 1:29 ` Mingbao Sun [this message]
2022-03-11 7:19 ` Christoph Hellwig
2022-03-11 16:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220311092916.00005266@tom.com \
--to=sunmingbao@tom.com \
--cc=ao.sun@dell.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=kuba@kernel.org \
--cc=libin.zhang@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ping.gan@dell.com \
--cc=tyler.sun@dell.com \
--cc=yanxiu.cai@dell.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).