From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CAA1DC433FE
	for <netdev@archiver.kernel.org>; Fri, 11 Mar 2022 08:40:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236303AbiCKIlA (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 11 Mar 2022 03:41:00 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39782 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234784AbiCKIk7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 11 Mar 2022 03:40:59 -0500
Received: from smtp.tom.com (smtprz02.163.net [106.3.154.235])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id D9E091BA156
        for <netdev@vger.kernel.org>; Fri, 11 Mar 2022 00:39:56 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
        by vip-app02.163.net (Postfix) with ESMTP id AFCFE44018D
        for <netdev@vger.kernel.org>; Fri, 11 Mar 2022 16:39:54 +0800 (CST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=mail;
        t=1646987994; bh=yYffQcBKLRbGtRWbyWPUTkTs+t8t9AmrQpNgV1htlDc=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=GZjSzy0zP24OwZ+qpi7pjb4aWf7F87a9LUjOpyNvuP/KdBZ2Y/nmtGYisC20ux6Zp
         0ZPPgUGgPsdS3Gocu7AsP7ysX7iBFNU9XgzmC7l0jg4ju0tQAvrxUJ1nUhObi0Mizg
         OqGI4DY3HIq+AVBFXO9i5vUIt1nCM7nvKNUx9z3I=
Received: from localhost (HELO smtp.tom.com) ([127.0.0.1])
          by localhost (TOM SMTP Server) with SMTP ID -1853934157
          for <netdev@vger.kernel.org>;
          Fri, 11 Mar 2022 16:39:54 +0800 (CST)
X-Virus-Scanned: Debian amavisd-new at mxtest.tom.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tom.com; s=mail;
        t=1646987994; bh=yYffQcBKLRbGtRWbyWPUTkTs+t8t9AmrQpNgV1htlDc=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=GZjSzy0zP24OwZ+qpi7pjb4aWf7F87a9LUjOpyNvuP/KdBZ2Y/nmtGYisC20ux6Zp
         0ZPPgUGgPsdS3Gocu7AsP7ysX7iBFNU9XgzmC7l0jg4ju0tQAvrxUJ1nUhObi0Mizg
         OqGI4DY3HIq+AVBFXO9i5vUIt1nCM7nvKNUx9z3I=
Received: from localhost (unknown [101.93.196.13])
        by antispamvip.163.net (Postfix) with ESMTPA id 8D22615414F8;
        Fri, 11 Mar 2022 16:39:49 +0800 (CST)
Date:   Fri, 11 Mar 2022 16:39:48 +0800
From:   Mingbao Sun <sunmingbao@tom.com>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        David Ahern <dsahern@kernel.org>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        tyler.sun@dell.com, ping.gan@dell.com, yanxiu.cai@dell.com,
        libin.zhang@dell.com, ao.sun@dell.com
Subject: Re: [PATCH 1/3] tcp: export symbol tcp_set_congestion_control
Message-ID: <20220311163948.000064d4@tom.com>
In-Reply-To: <20220311071319.GA18222@lst.de>
References: <20220311030113.73384-1-sunmingbao@tom.com>
        <20220311030113.73384-2-sunmingbao@tom.com>
        <20220311071319.GA18222@lst.de>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-w64-mingw32)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 11 Mar 2022 08:13:19 +0100
Christoph Hellwig <hch@lst.de> wrote:

> Maybe add a kerneldoc comment now that this is an exported API?
> 
> Otherwise this looks fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

accept.

will add it in the next version.
and will notice user "Must be called on a locked sock".