From: Stephen Hemminger <stephen@networkplumber.org>
To: Eli Cohen <elic@nvidia.com>
Cc: <dsahern@kernel.org>, <netdev@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<jasowang@redhat.com>, <si-wei.liu@oracle.com>, <mst@redhat.com>,
<lulu@redhat.com>, <parav@nvidia.com>
Subject: Re: [PATCH v7 2/4] vdpa: Allow for printing negotiated features of a device
Date: Sun, 13 Mar 2022 10:33:56 -0700 [thread overview]
Message-ID: <20220313103356.2df9ac45@hermes.local> (raw)
In-Reply-To: <20220313171219.305089-3-elic@nvidia.com>
On Sun, 13 Mar 2022 19:12:17 +0200
Eli Cohen <elic@nvidia.com> wrote:
> + if (feature_strs)
> + s = feature_strs[i];
> + else
> + s = NULL;
You really don't like trigraphs?
s = feature_strs ? feature_strs[i] : NULL;
is more compact
next prev parent reply other threads:[~2022-03-13 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-13 17:12 [PATCH v7 0/4] vdpa tool enhancements Eli Cohen
2022-03-13 17:12 ` [PATCH v7 1/4] vdpa: Remove unsupported command line option Eli Cohen
2022-03-13 17:12 ` [PATCH v7 2/4] vdpa: Allow for printing negotiated features of a device Eli Cohen
2022-03-13 17:33 ` Stephen Hemminger [this message]
2022-03-13 18:04 ` Eli Cohen
2022-03-14 14:51 ` David Ahern
2022-03-14 14:54 ` Eli Cohen
2022-03-14 15:07 ` David Ahern
2022-03-14 15:34 ` Eli Cohen
2022-03-14 16:00 ` David Ahern
2022-03-15 11:35 ` Eli Cohen
2022-03-16 15:46 ` David Ahern
2022-03-13 17:12 ` [PATCH v7 3/4] vdpa: Support for configuring max VQ pairs for " Eli Cohen
2022-03-14 15:09 ` David Ahern
2022-03-14 15:35 ` Eli Cohen
2022-03-14 15:45 ` Eli Cohen
2022-03-14 16:01 ` David Ahern
2022-03-13 17:12 ` [PATCH v7 4/4] vdpa: Support reading device features Eli Cohen
2022-03-14 15:10 ` [PATCH v7 0/4] vdpa tool enhancements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220313103356.2df9ac45@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).