From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4E2C433FE for ; Tue, 15 Mar 2022 14:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349394AbiCOOni (ORCPT ); Tue, 15 Mar 2022 10:43:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349382AbiCOOnh (ORCPT ); Tue, 15 Mar 2022 10:43:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C383355BD1; Tue, 15 Mar 2022 07:42:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6008A60EF2; Tue, 15 Mar 2022 14:42:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 417C9C340EE; Tue, 15 Mar 2022 14:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647355340; bh=5n0xBkaFOIdU9mVDR5qVSvVvGAOz04JEo64OXCp4opI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dP17JQFCg6ehWM3a7uT5yOW6ACxF0Ek+UH8tru8urs9QSY0gIhAHmY5uowM0ooSIW GOa/KLnQwB+vdUEjNK1nbrKM1FdixTo0ME9pgz63pXjbkaI4eCEyCOh1bQBRu86vOL ppI04yj6SxB9sorGMppVnKDdgvjVsS09HGD8JG33WfDYeY/LMByiBDaPb3oNkmEUIe BNs5/p/9nsUpmxsbLMbdRddaa2vhiz44usjk4XicDi9mDG4XYMCVooB1Y8+MvEjygx OcZkFv4BeKUZRl2rkM0xTpN1E/prEJN4pbEId1D2IEr/g+UPqihOwUuHdI+5hyrfpS qvx6IrOmSvPfA== Date: Tue, 15 Mar 2022 23:42:14 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: Jiri Olsa , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Andrii Nakryiko , netdev@vger.kernel.org, bpf@vger.kernel.org, lkml , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Steven Rostedt , "Naveen N . Rao" , Anil S Keshavamurthy , "David S . Miller" Subject: Re: [PATCH v12 bpf-next 00/12] fprobe: Introduce fprobe function entry/exit probe Message-Id: <20220315234214.c9dee345347be30450061ac8@kernel.org> In-Reply-To: <164735281449.1084943.12438881786173547153.stgit@devnote2> References: <164735281449.1084943.12438881786173547153.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 15 Mar 2022 23:00:14 +0900 Masami Hiramatsu wrote: > Hi, > > Here is the 12th version of fprobe. This version fixes a possible gcc-11 issue which > was reported as kretprobes on arm issue, and also I updated the fprobe document. Here is the gcc-11 build issue thread for reference. https://lore.kernel.org/all/202203150516.KTorSVVU-lkp@intel.com/T/#u Thank you, > > The previous version (v11) is here[1]; > > [1] https://lore.kernel.org/all/164701432038.268462.3329725152949938527.stgit@devnote2/T/#u > > This series introduces the fprobe, the function entry/exit probe > with multiple probe point support for x86, arm64 and powerpc64le. > This also introduces the rethook for hooking function return as same as > the kretprobe does. This abstraction will help us to generalize the fgraph > tracer, because we can just switch to it from the rethook in fprobe, > depending on the kernel configuration. > > The patch [1/12] is from Jiri's series[2]. > > [2] https://lore.kernel.org/all/20220104080943.113249-1-jolsa@kernel.org/T/#u > > And the patch [9/10] adds the FPROBE_FL_KPROBE_SHARED flag for the case > if user wants to share the same code (or share a same resource) on the > fprobe and the kprobes. > > I forcibly updated my kprobes/fprobe branch, you can pull this series > from: > > https://git.kernel.org/pub/scm/linux/kernel/git/mhiramat/linux.git kprobes/fprobe > > Thank you, > > --- > > Jiri Olsa (1): > ftrace: Add ftrace_set_filter_ips function > > Masami Hiramatsu (11): > fprobe: Add ftrace based probe APIs > rethook: Add a generic return hook > rethook: x86: Add rethook x86 implementation > arm64: rethook: Add arm64 rethook implementation > powerpc: Add rethook support > ARM: rethook: Add rethook arm implementation > fprobe: Add exit_handler support > fprobe: Add sample program for fprobe > fprobe: Introduce FPROBE_FL_KPROBE_SHARED flag for fprobe > docs: fprobe: Add fprobe description to ftrace-use.rst > fprobe: Add a selftest for fprobe > > > Documentation/trace/fprobe.rst | 174 +++++++++++++ > Documentation/trace/index.rst | 1 > arch/arm/Kconfig | 1 > arch/arm/include/asm/stacktrace.h | 4 > arch/arm/kernel/stacktrace.c | 6 > arch/arm/probes/Makefile | 1 > arch/arm/probes/rethook.c | 103 ++++++++ > arch/arm64/Kconfig | 1 > arch/arm64/include/asm/stacktrace.h | 2 > arch/arm64/kernel/probes/Makefile | 1 > arch/arm64/kernel/probes/rethook.c | 25 ++ > arch/arm64/kernel/probes/rethook_trampoline.S | 87 +++++++ > arch/arm64/kernel/stacktrace.c | 7 - > arch/powerpc/Kconfig | 1 > arch/powerpc/kernel/Makefile | 1 > arch/powerpc/kernel/rethook.c | 72 +++++ > arch/x86/Kconfig | 1 > arch/x86/include/asm/unwind.h | 8 + > arch/x86/kernel/Makefile | 1 > arch/x86/kernel/kprobes/common.h | 1 > arch/x86/kernel/rethook.c | 119 +++++++++ > include/linux/fprobe.h | 105 ++++++++ > include/linux/ftrace.h | 3 > include/linux/kprobes.h | 3 > include/linux/rethook.h | 100 ++++++++ > include/linux/sched.h | 3 > kernel/exit.c | 2 > kernel/fork.c | 3 > kernel/trace/Kconfig | 26 ++ > kernel/trace/Makefile | 2 > kernel/trace/fprobe.c | 332 +++++++++++++++++++++++++ > kernel/trace/ftrace.c | 58 ++++ > kernel/trace/rethook.c | 317 ++++++++++++++++++++++++ > lib/Kconfig.debug | 12 + > lib/Makefile | 2 > lib/test_fprobe.c | 174 +++++++++++++ > samples/Kconfig | 7 + > samples/Makefile | 1 > samples/fprobe/Makefile | 3 > samples/fprobe/fprobe_example.c | 120 +++++++++ > 40 files changed, 1876 insertions(+), 14 deletions(-) > create mode 100644 Documentation/trace/fprobe.rst > create mode 100644 arch/arm/probes/rethook.c > create mode 100644 arch/arm64/kernel/probes/rethook.c > create mode 100644 arch/arm64/kernel/probes/rethook_trampoline.S > create mode 100644 arch/powerpc/kernel/rethook.c > create mode 100644 arch/x86/kernel/rethook.c > create mode 100644 include/linux/fprobe.h > create mode 100644 include/linux/rethook.h > create mode 100644 kernel/trace/fprobe.c > create mode 100644 kernel/trace/rethook.c > create mode 100644 lib/test_fprobe.c > create mode 100644 samples/fprobe/Makefile > create mode 100644 samples/fprobe/fprobe_example.c > > -- > Masami Hiramatsu (Linaro) -- Masami Hiramatsu