Re: [PATCH net-next 0/3] bridge: dsa: switchdev: mv88e6xxx: Implement local_receive bridge flag

Florian Fainelli
2022-03-01T17:14:26Z

On 3/1/2022 4:31 AM, Mattias Forsblad wrote:
> Greetings,
>
> This series implements a new bridge flag 'local_receive' and HW
> offloading for Marvell mv88e6xxx.
>
> When using a non-VLAN filtering bridge we want to be able to limit
> traffic to the CPU port to lessen the CPU load. This is specially
> important when we have disabled learning on user ports.
>
> A sample configuration could be something like this:
>
> br0
> / \
> swp0 swp1
>
> ip link add dev br0 type bridge stp_state 0 vlan_filtering 0
> ip link set swp0 master br0
> ip link set swp1 master br0
> ip link set swp0 type bridge_slave learning off
> ip link set swp1 type bridge_slave learning off
> ip link set swp0 up
> ip link set swp1 up
> ip link set br0 type bridge local_receive 0
> ip link set br0 up
>
> The first part of the series implements the flag for the SW bridge
> and the second part the DSA infrastructure. The last part implements
> offloading of this flag to HW for mv88e6xxx, which uses the
> port vlan table to restrict the ingress from user ports
> to the CPU port when this flag is cleared.

Why not use a bridge with VLAN filtering enabled? I cannot quite find it
right now, but Vladimir recently picked up what I had attempted before
which was to allow removing the CPU port (via the bridge master device)
from a specific group of VLANs to achieve that isolation.

>
> Reviewed-by: Tobias Waldekranz <tobias@waldekranz.com>

I don't believe this tag has much value since it was presumably carried
over from an internal review. Might be worth adding it publicly now, though.

>
> Regards,
> Mattias Forsblad (3):
> net: bridge: Implement bridge flag local_receive
> dsa: Handle the local_receive flag in the DSA layer.
> mv88e6xxx: Offload the local_receive flag
>
> drivers/net/dsa/mv88e6xxx/chip.c | 45 ++++++++++++++++++++++++++++++--
> include/linux/if_bridge.h | 6 +++++
> include/net/dsa.h | 6 +++++
> include/net/switchdev.h | 2 ++
> include/uapi/linux/if_bridge.h | 1 +
> include/uapi/linux/if_link.h | 1 +
> net/bridge/br.c | 18 +++++++++++++
> net/bridge/br_device.c | 1 +
> net/bridge/br_input.c | 3 +++
> net/bridge/br_ioctl.c | 1 +
> net/bridge/br_netlink.c | 14 +++++++++-
> net/bridge/br_private.h | 2 ++
> net/bridge/br_sysfs_br.c | 23 ++++++++++++++++
> net/bridge/br_vlan.c | 8 ++++++
> net/dsa/dsa_priv.h | 1 +
> net/dsa/slave.c | 16 ++++++++++++
> 16 files changed, 145 insertions(+), 3 deletions(-)
>

--
Florian